Alexisiba/relative and default url refactor#316
Merged
Conversation
Reviewer's GuideThis PR refactors URL handling in ComponentBase to remove the relative flag and unify safeUrl logic using window.location as base, updates domain checks for target icons, adjusts AuroHyperlink target attribute behavior, aligns tests with the new URL resolution, and refreshes package and environment configurations. Sequence diagram for safeUrl resolution with window.locationsequenceDiagram
participant ComponentBase
participant "window.location"
ComponentBase->>"window.location": Use window.location.href as base for new URL(href)
"window.location"-->>ComponentBase: Returns resolved URL
ComponentBase->>ComponentBase: Set protocol to https
ComponentBase-->>ComponentBase: Return url.href
Sequence diagram for targetIcon domain check logicsequenceDiagram
participant ComponentBase
participant "window.location"
participant "newWindow.svg"
participant "externalLink.svg"
ComponentBase->>"window.location": Compare safeUri hostname to window.location.hostname
alt Hostnames match
ComponentBase->>"newWindow.svg": generateIconHtml(newWindow.svg)
else Hostnames differ
ComponentBase->>"externalLink.svg": generateIconHtml(externalLink.svg)
end
Class diagram for updated ComponentBase URL handlingclassDiagram
class ComponentBase {
- appearance: string
- download: boolean
- ondark: boolean
- variant: string
- href: string
+ get safeUri()
+ safeUrl(href)
+ targetIcon(target)
}
ComponentBase <|-- AuroHyperlink
Class diagram for updated AuroHyperlink target attribute logicclassDiagram
class AuroHyperlink {
+ target: string
+ includesDomain: boolean
+ relative: boolean
+ render()
}
AuroHyperlink --|> ComponentBase
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/component-base.mjs:239-238` </location>
<code_context>
return undefined;
}
- const url = new URL(href, "https://www.alaskaair.com");
+ const url = new URL(href, window?.location?.href);
switch (url.protocol) {
</code_context>
<issue_to_address>
**issue (bug_risk):** Switching URL base to window.location.href may cause issues in non-browser environments.
This approach can cause runtime errors in SSR or non-browser environments where window is undefined. Please add a guard or fallback to handle these cases.
</issue_to_address>
### Comment 2
<location> `test/auro-hyperlink.test.js:37-44` </location>
<code_context>
);
});
+ it("auro-hyperlink href is absolute URL", async () => {
+ const el = await fixture(html`
+ <auro-hyperlink href="https://alaskaair.com/auro">It's Auro!</auro-hyperlink>
+ `);
+
+ const anchor = el.shadowRoot.querySelector("a");
+
+ expect(anchor).to.have.attribute("href", "https://alaskaair.com/auro");
+ });
+
</code_context>
<issue_to_address>
**suggestion (testing):** Add tests for invalid or malformed absolute URLs.
Consider adding tests for cases like missing or unsupported protocols to ensure robust handling of malformed URLs.
Suggested implementation:
```javascript
it("auro-hyperlink href is absolute URL", async () => {
const el = await fixture(html`
<auro-hyperlink href="https://alaskaair.com/auro">It's Auro!</auro-hyperlink>
`);
const anchor = el.shadowRoot.querySelector("a");
expect(anchor).to.have.attribute("href", "https://alaskaair.com/auro");
});
it("auro-hyperlink handles malformed absolute URL (missing protocol)", async () => {
const el = await fixture(html`
<auro-hyperlink href="alaskaair.com/auro">It's Auro!</auro-hyperlink>
`);
const anchor = el.shadowRoot.querySelector("a");
// Expect the href to be rendered as-is, or not at all, depending on component behavior
expect(anchor).to.have.attribute("href", "alaskaair.com/auro");
});
it("auro-hyperlink handles unsupported protocol in absolute URL", async () => {
const el = await fixture(html`
<auro-hyperlink href="ftp://alaskaair.com/auro">It's Auro!</auro-hyperlink>
`);
const anchor = el.shadowRoot.querySelector("a");
// Expect the href to be rendered as-is, or not at all, depending on component behavior
expect(anchor).to.have.attribute("href", "ftp://alaskaair.com/auro");
});
```
If your component is supposed to validate or sanitize URLs, you may need to update its implementation to handle these cases accordingly. Adjust the assertions if the component is expected to block or modify malformed/unsupported URLs.
</issue_to_address>
### Comment 3
<location> `test/auro-hyperlink.test.js:165` </location>
<code_context>
+describe("safeUrl function", () => {
</code_context>
<issue_to_address>
**suggestion (testing):** Update safeUrl tests to reflect new default base URL behavior.
Please ensure tests cover resolution of relative URLs using window.location.href as the base, rather than the previous hardcoded value.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
7 tasks
alexisiba
force-pushed
the
alexisiba/relative-and-default-url-refactor
branch
from
November 19, 2025 00:11
343be70 to
8095785
Compare
|
🚀 PR Release Published! To install: npm install @aurodesignsystem-dev/auro-hyperlink@0.0.0-pr316.2Install via alias: npm install @aurodesignsystem/auro-hyperlink@npm:@aurodesignsystem-dev/auro-hyperlink@0.0.0-pr316.2 |
alexisiba
force-pushed
the
alexisiba/relative-and-default-url-refactor
branch
from
November 19, 2025 01:58
8095785 to
a6c171c
Compare
7 tasks
7 tasks
rmenner
force-pushed
the
alexisiba/relative-and-default-url-refactor
branch
from
November 19, 2025 05:18
a6c171c to
1cd7258
Compare
rmenner
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Refactor URL resolution to always use the current origin, remove legacy relative URL support, and streamline link target and icon logic while updating related tests and build configs
Enhancements:
Build:
Tests: