Skip to content

AURO MIGRATION: Setup 'Trusted Publishing (OIDC)' for GitHub Actions#314

Merged
rmenner merged 3 commits into
devfrom
rmenner/ci/oidc-release-upgrade
Nov 4, 2025
Merged

AURO MIGRATION: Setup 'Trusted Publishing (OIDC)' for GitHub Actions#314
rmenner merged 3 commits into
devfrom
rmenner/ci/oidc-release-upgrade

Conversation

@rmenner

@rmenner rmenner commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Resolves AlaskaAirlines/auro-cli#219

Summary by Sourcery

Configure the package for OIDC-based trusted publishing by enabling npm provenance, updating dependencies, relaxing the Node.js engine requirement, and adding a .nvmrc file

Enhancements:

  • Relax Node.js engine requirement to ">=20"
  • Bump @aurodesignsystem/auro-config dependency to ^1.3.1
  • Enable npm package provenance in publishConfig

Chores:

  • Add .nvmrc file for Node.js version consistency

@rmenner
rmenner requested a review from a team as a code owner November 4, 2025 02:00
@rmenner rmenner self-assigned this Nov 4, 2025
@sourcery-ai

sourcery-ai Bot commented Nov 4, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR configures the project for trusted OIDC publishing by enabling provenance metadata, standardizes the Node version requirement, bumps the config dependency, and updates the lockfile accordingly.

Class diagram for updated package.json configuration

classDiagram
    class PackageJson {
        +String engines.node
        +Object dependencies
        +Object publishConfig
    }
    PackageJson : engines.node = ">=20"
    PackageJson : dependencies["@aurodesignsystem/auro-config"] = "^1.3.1"
    PackageJson : publishConfig.access = "public"
    PackageJson : publishConfig.provenance = true
Loading

File-Level Changes

Change Details Files
Standardize Node version requirement
  • Simplify engines.node to “>=20”
  • Add .nvmrc to pin Node version
package.json
.nvmrc
Enable trusted publishing metadata
  • Add “provenance”: true under publishConfig
package.json
package-lock.json
Bump config dependency version
  • Update @aurodesignsystem/auro-config to ^1.3.1
package.json
package-lock.json
Refresh lockfile
  • Regenerate package-lock.json to reflect dependency and config changes
package-lock.json

Assessment against linked issues

Issue Objective Addressed Explanation
AlaskaAirlines/auro-cli#219 Set up Trusted Publishing (OIDC) for GitHub Actions in the auro-cli project.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The PR title mentions Trusted Publishing (OIDC) for GitHub Actions but there are no workflow yml updates—ensure your GitHub Actions config is updated to leverage the new provenance setting and OIDC tokens.
  • Your .nvmrc file should match the 'node' engine version in package.json to avoid discrepancies between local dev and CI environments.
  • Consider pinning a tested Node version range instead of >=20 to prevent unexpected breakages from future major Node releases.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The PR title mentions Trusted Publishing (OIDC) for GitHub Actions but there are no workflow yml updates—ensure your GitHub Actions config is updated to leverage the new provenance setting and OIDC tokens.
- Your .nvmrc file should match the 'node' engine version in package.json to avoid discrepancies between local dev and CI environments.
- Consider pinning a tested Node version range instead of `>=20` to prevent unexpected breakages from future major Node releases.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rmenner
rmenner merged commit cd5cf12 into dev Nov 4, 2025
13 checks passed
@rmenner
rmenner deleted the rmenner/ci/oidc-release-upgrade branch November 4, 2025 22:46
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 7.0.0-rc-320.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released Completed work has been released label Nov 19, 2025
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 7.0.0-rc-329.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 7.0.0-rc-336.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 7.0.0-rc-339.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auro-cli: Setup Trusted Publishing (OIDC) for GitHub Actions

2 participants