AURO MIGRATION: Setup 'Trusted Publishing (OIDC)' for GitHub Actions#314
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR configures the project for trusted OIDC publishing by enabling provenance metadata, standardizes the Node version requirement, bumps the config dependency, and updates the lockfile accordingly. Class diagram for updated package.json configurationclassDiagram
class PackageJson {
+String engines.node
+Object dependencies
+Object publishConfig
}
PackageJson : engines.node = ">=20"
PackageJson : dependencies["@aurodesignsystem/auro-config"] = "^1.3.1"
PackageJson : publishConfig.access = "public"
PackageJson : publishConfig.provenance = true
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The PR title mentions Trusted Publishing (OIDC) for GitHub Actions but there are no workflow yml updates—ensure your GitHub Actions config is updated to leverage the new provenance setting and OIDC tokens.
- Your .nvmrc file should match the 'node' engine version in package.json to avoid discrepancies between local dev and CI environments.
- Consider pinning a tested Node version range instead of
>=20to prevent unexpected breakages from future major Node releases.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title mentions Trusted Publishing (OIDC) for GitHub Actions but there are no workflow yml updates—ensure your GitHub Actions config is updated to leverage the new provenance setting and OIDC tokens.
- Your .nvmrc file should match the 'node' engine version in package.json to avoid discrepancies between local dev and CI environments.
- Consider pinning a tested Node version range instead of `>=20` to prevent unexpected breakages from future major Node releases.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
🎉 This PR is included in version 7.0.0-rc-320.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.0.0-rc-329.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.0.0-rc-336.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.0.0-rc-339.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-cli#219
Summary by Sourcery
Configure the package for OIDC-based trusted publishing by enabling npm provenance, updating dependencies, relaxing the Node.js engine requirement, and adding a .nvmrc file
Enhancements:
Chores: