fix: fixed for auro-hyperlink not being rendered when relative and ta…

[alexisiba]

…rget='_blank' are set

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

• My update follows the CONTRIBUTING guidelines of this project
• I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix auro-hyperlink support for relative URLs by normalizing hrefs properly and treating them as internal so target attributes are applied

Bug Fixes:

• Update href normalization regex to strip optional protocols and unify leading slashes for relative links
• Consider relative URLs as internal domain in isAlaskaAirDomain and allow target attribute when relative

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances ComponentBase to correctly normalize and detect relative URLs as internal links, and updates AuroHyperlink to allow rendering the target attribute for those relative links.

Class diagram for updated ComponentBase and AuroHyperlink

classDiagram
    class ComponentBase {
        +isRelativeUrl(href)
        +normalizeUrl(href)
        +isAlaskaAirDomain(url)
        +relative : boolean
    }
    class AuroHyperlink {
        +target : string
        +includesDomain : boolean
        +relative : boolean
    }
    ComponentBase <|-- AuroHyperlink

Loading

Flow diagram for target attribute rendering logic in AuroHyperlink

flowchart TD
    A["User provides href to AuroHyperlink"] --> B["Check if href is relative"]
    B -->|Yes| C["Set relative = true"]
    B -->|No| D["Check if href includes AlaskaAir domain"]
    C --> E["target attribute rendered if target is set"]
    D --> F["target attribute rendered if target is set and includesDomain is true"]

Loading

File-Level Changes

Change	Details	Files
Improve relative URL normalization and domain detection in ComponentBase	Adjust href normalization regex to strip protocols and normalize leading slashes for relative paths Treat relative URLs as internal AlaskaAir domain in isAlaskaAirDomain logic	src/component-base.mjs
Allow AuroHyperlink to render target attribute for relative links	Include relative URL flag in target attribute condition alongside domain check	src/auro-hyperlink.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#311	Ensure that auro-hyperlink elements with both target="_blank" and the relative attribute render correctly.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider adding a guard in isRelativeUrl to handle non-string or empty inputs so you don’t run into runtime errors when url is undefined or null.
• You might extract isRelativeUrl and the domain check into a shared URL utility module for better reuse across components and easier standalone testing.
• The regex in isRelativeUrl currently only blocks http(s) and protocol-relative URLs; consider extending it to explicitly exclude other schemes (e.g., mailto:, javascript:) if those should not be treated as relative.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding a guard in isRelativeUrl to handle non-string or empty inputs so you don’t run into runtime errors when url is undefined or null.
- You might extract isRelativeUrl and the domain check into a shared URL utility module for better reuse across components and easier standalone testing.
- The regex in isRelativeUrl currently only blocks http(s) and protocol-relative URLs; consider extending it to explicitly exclude other schemes (e.g., mailto:, javascript:) if those should not be treated as relative.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jordanjones243]

Something here is still broken. To reproduce this issue, I used this code:

<auro-hyperlink target="_blank" href="/assets/icons/plane.svg" relative>No href supplied</auro-hyperlink><br>
Welcome to <auro-hyperlink target="_blank" href="/assets/icons/plane.svg" relative>Alaska Airlines</auro-hyperlink>.

When testing, I noticed that the first link rendered just fine, but the second link with text surrounding the component is still broke. Let me know if you do not see the same thing and need to discuss this further.

The changes requested are done

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `src/component-base.mjs:258-262` </location>
<code_context>
           return url.href;
         }
-        return href.replace(/^[^:]+:/, "");
+        /**
+         * This regex checks if the provided href starts with http:, http:, ftp:, etc...
+         * Also checks if it has // if that matches it replaces it for just one /
+         */
+        return href.replace(/^(?:[^:]+:)?\/\/?/, "/");
     }
   }
</code_context>

<issue_to_address>
**issue (bug_risk):** The updated regex may unintentionally convert protocol-relative URLs to root-relative paths.

This change may break links intended to preserve the host. Please confirm if this behavior is intentional and appropriate for all use cases.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

🚀 PR Release Published! v0.0.0-pr312.1

To install:

npm install @aurodesignsystem-dev/auro-hyperlink@0.0.0-pr312.1

Install via alias:

npm install @aurodesignsystem/auro-hyperlink@npm:@aurodesignsystem-dev/auro-hyperlink@0.0.0-pr312.1

View on npmjs.com

[github-actions]

🎉 This PR is included in version 7.0.0-rc-320.1 🎉

The release is available on:

• npm package (@rc dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 7.0.0-rc-329.1 🎉

The release is available on:

• npm package (@rc dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 7.0.0-rc-336.1 🎉

The release is available on:

• npm package (@rc dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 7.0.0-rc-339.1 🎉

The release is available on:

• npm package (@rc dist-tag)
• GitHub release

Your semantic-release bot 📦🚀