Conversation
Reviewer's GuideAdds detailed release notes for version 6.0.1, documenting combobox focus/displayValue fixes, dropdown focus-management changes, input slot-handling improvements, associated test coverage, and a linked post-mortem document. Sequence diagram for updated focus routing on combobox option clicksequenceDiagram
actor User
participant auroCombobox
participant auroDropdown
participant auroInput
participant clearBtn
User->>auroCombobox: clickOption()
auroCombobox->>auroDropdown: closeDropdown(noFocusRestoreOnClose = true)
auroDropdown-->>auroDropdown: [noFocusRestoreOnClose suppresses focusTrigger]
auroCombobox->>auroInput: input.focus()
auroCombobox->>clearBtn: clearBtn.focus()
clearBtn-->>User: focus visible on clear button
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider briefly defining terms like “bib” the first time they’re used so the release notes are understandable to readers who aren’t familiar with internal component jargon.
- You might want to explicitly call out which behavior changes could affect keyboard and screen reader interactions in a short accessibility-focused subsection to make the impact easier to scan.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider briefly defining terms like “bib” the first time they’re used so the release notes are understandable to readers who aren’t familiar with internal component jargon.
- You might want to explicitly call out which behavior changes could affect keyboard and screen reader interactions in a short accessibility-focused subsection to make the impact easier to scan.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…y and error handling. review of: #1556
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…r in grouped controls
…ntainer review of: #1563
Three defenses against shipping unbundled @aurodesignsystem/* imports in
published dist files:
- test/check-bundled-imports.mjs scans every
components/*/dist/{index,registered}.js
for bare specifiers outside an allowlist derived from
EXTERNAL_PACKAGE_NAMES.
- internal.rollup.config.mjs throws on UNRESOLVED_IMPORT via onwarn and
exports EXTERNAL_PACKAGE_NAMES so rollup's external array and the check
script's allowlist share one source of truth.
- pull-request.yml and release.yml run `npm run test:dist` via
additional-build-command so the cache save (and the rest of the workflow)
fails if a malformed dist is produced.
See docs/post-mortem/1575423.md for the failure timeline, reproduction
steps, and the trade-off discussion.
…defenses against unresolved imports
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…ng and width AB#1457608 - combobox: call showBib() from handleMenuLoadingChange when loading becomes true so the bib opens immediately when consumers set loading via inputValue - menu: hardcode nocheckmark on the shadow DOM loading placeholder; the noCheckmark propagation loop only queries light DOM, leaving the shadow placeholder with 44px padding instead of 12px - menu: replace inline-block + margin-bottom layout on loadingWrapper with flexbox so the spinner and text are properly vertically centered Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 6.0.0-rc-1560.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Release candidate pull request. See issue #1560 for details.
Review Checklist:
RC Checklist
Testing Checklist:
Browsers
Browsers Support Guide
Dev demo link
Android
iOS
Desktop
Scenarios
Framework playground
**By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team