RC #1484#1485
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
|
|
| Test | Priority | Why |
|---|---|---|
Enter on collapsed empty combobox does not call preventDefault() |
P0 | Prevents regression of P0-1 |
| Alt+ArrowUp closes popup without selection | P1 | APG contract |
Filter result count is announced via srAnnouncement |
P1 | Covers P1-4 |
auroMenu-selectValueFailure refreshes trigger label |
P1 | Covers P1-5 |
| Shift+Tab matches documented behavior | P1 | Covers P1-3 |
persistInput + menu-option click → clear-button focus |
P1 | Existing test currently commented out |
| Esc from modal close button restores trigger focus | P2 | Native cancel path bypasses strategy |
| Ctrl+Arrow support in combobox | P2 | Feature exists but lacks coverage |
disconnectedCallback cleans up timeouts and sync flags |
P3 | Hygiene |
Suggested Merge Gate
Must Fix Before Merge
- P0-1 — Enter blocks form submission
- P0-2 — Missing
aria-autocomplete - P0-3 — Dual
aria-activedescendantwiring
Should Fix Before Merge
- P1-1 —
persistInputregression - P1-2 — Alt+ArrowUp APG violation
- P1-3 — Shift+Tab doc/code drift
- P1-4 — Missing result-count announcements
- P1-5 — Stale trigger label after selection failure
Follow-Up Issues
- All P2 findings
Nice-to-Haves
- All P3 findings
Final Assessment
The major regressions are concentrated around keyboard accessibility, combobox ARIA semantics, and focus management. The broader combobox/select synchronization work appears structurally sound, but the P0 and P1 findings should be addressed before merging dev into main.
|
|
…t intent Adds two tests inside the existing Enter describe block verifying that pressing Enter on auro-select — whether closed (opens bib) or open (selects option) — does not propagate to a parent <form>. Also adds an explanatory comment to the Enter handler in selectKeyboardStrategy.js noting that the unconditional preventDefault/stopPropagation matches APG and native <select> behavior.
combobox trigger Match the WAI-ARIA APG select-only combobox reference markup. The implicit default of aria-haspopup on role="combobox" is "listbox", but setting it explicitly avoids relying on UA implicit-value mapping fidelity.
option changes Subscribe to auroMenu-optionsChange so screen readers announce accurate positions after dynamic option mutations (slotchange, async/lazy loads, value-triggered re-init). Previously these attributes were set once at init and went stale.
Locks in the WAI-ARIA APG select-only combobox contract that Tab must perform its default action so focus advances to the next tabbable element. Prevents future regressions that would trap focus on the trigger by adding preventDefault to the Tab handler.
The `options` reactive state property (@Private) was assigned in configureMenu and the auroMenu-optionsChange listener but never read. Its implicit Lit re-render trigger was masking the real dependency: renderNativeSelect reads this.menu.options directly. Replace both assignments with explicit this.requestUpdate() calls so the intent — re-stamping the hidden native <option> list after menu mutations — is obvious at the call site. Add a regression test asserting the hidden native <select> re-renders when menu options are added at runtime.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Selection listener's setClearBtnFocus was clobbering Shift+Tab focus. Added a per-selection suppress flag the listener uses, then move focus to the previous page selectable option.
Skip preventDefault when no previous tab stop is found, use checkVisibility() with a fallback so position:fixed elements aren't dropped, and clear the suppress flag via microtask so a no-op makeSelection can't leak it.
…lity and customize documentation
…278416 Adds a docs example, customize.md section, unit test, and storybook play-function test.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…board behavior tests
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Alaska Airlines Pull Request
Release candidate pull request. See issue #1484 for details.
Review Checklist:
RC Checklist
Testing Checklist:
Browsers
Browsers Support Guide
Dev demo link
Android
iOS
Desktop
Scenarios
Framework playground
**By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team