Skip to content

Rmenner/test pr#6

Merged
rmenner merged 4 commits into
devfrom
rmenner/test-pr
Jan 16, 2026
Merged

Rmenner/test pr#6
rmenner merged 4 commits into
devfrom
rmenner/test-pr

Conversation

@rmenner

@rmenner rmenner commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update demo and pull request workflows to use the new local demo build setup for the auro-formkit demo.

Enhancements:

  • Refine npm scripts for running, building, and zipping the local demo to better separate concerns.

Build:

  • Configure dev demo workflow to publish the auro-formkit demo directory.
  • Update pull request workflow to run the local demo build for auro-formkit and adjust related inputs and secrets.

Documentation:

  • Adjust the auro-input demo page title to reflect test usage.

- Update dev-demo.yml to include publish directory and build command for demo
- Remove unused AURO_SURGE_TOKEN from pull-request.yml
- Add 'gh-demo' script to package.json for building demo
@sourcery-ai

sourcery-ai Bot commented Jan 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub workflows to use the shared dev-demo and pull-request actions with new demo-specific parameters, adjusts local demo npm scripts for more flexible build/zip flows, and tweaks the input component demo title text.

Flow diagram for updated local demo npm scripts

flowchart TD
  subgraph NPM_Scripts
    A[npm run local-demo]
    B[npm run local-demo:build]
    C[npm run local-demo:zip]
    D[npm run build]
    E[local-demo_sh]
  end

  A -->|runs| E
  B -->|runs| D
  B -->|then runs| A
  C -->|runs| B
  C -->|forwards --zip to| E
Loading

File-Level Changes

Change Details Files
Update dev branch demo workflow to configure publish directory for shared dev-demo action.
  • Retain use of shared dev-demo workflow from AlaskaAirlines/auro-actions@dev
  • Introduce with.publish-dir parameter pointing to ./auro-formkit-demo
  • Remove unused pull_request trigger from dev-demo workflow
.github/workflows/dev-demo.yml
Reconfigure pull-request workflow to build and serve the auro-formkit demo instead of component-matrix config, and simplify secrets.
  • Keep usage of shared pull-request workflow from AlaskaAirlines/auro-actions@dev
  • Replace component and is-monorepo inputs with demo-dir and demo-build-command to run npm run local-demo for ./auro-formkit-demo
  • Maintain cache directories list for components builds and node_modules
  • Remove AURO_SURGE_TOKEN secret while preserving NPM_TOKEN
.github/workflows/pull-request.yml
Refine local demo npm scripts to separate build, run, and zip flows.
  • Change local-demo script to only run local-demo.sh without build or zip flags
  • Add local-demo:build script to build then run local-demo
  • Add local-demo:zip script to build, run local-demo, and pass through --zip flag
package.json
Adjust input component demo page title text for testing or clarification.
  • Append the word 'test' to the auro-input demo page title in the HTML head
components/input/demo/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • In .github/workflows/dev-demo.yml, the pull_request trigger was removed entirely—if that wasn’t intentional, consider re-adding it or documenting why dev demo runs are no longer needed on PRs.
  • The new inputs demo-dir and demo-build-command in .github/workflows/pull-request.yml should be double‑checked against the reusable workflow’s expected input names and semantics to avoid runtime failures.
  • The change to the input demo page title (auro-input test) looks like a temporary/testing tweak; consider whether this should be reverted or renamed to something production-appropriate.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `.github/workflows/dev-demo.yml`, the `pull_request` trigger was removed entirely—if that wasn’t intentional, consider re-adding it or documenting why dev demo runs are no longer needed on PRs.
- The new inputs `demo-dir` and `demo-build-command` in `.github/workflows/pull-request.yml` should be double‑checked against the reusable workflow’s expected input names and semantics to avoid runtime failures.
- The change to the input demo page title (`auro-input test`) looks like a temporary/testing tweak; consider whether this should be reverted or renamed to something production-appropriate.

## Individual Comments

### Comment 1
<location> `.github/workflows/pull-request.yml:15` </location>
<code_context>
-      component: '["checkbox", "combobox", "counter", "datepicker", "dropdown", "form", "input", "menu", "radio", "select"]'
-      is-monorepo: true
+      demo-dir: './auro-formkit-demo'
+      demo-build-command: 'npm run local-demo'
       cache-dirs: |
         ./components/**/dist
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Consider using the new `local-demo:build` script so the demo is built before running

`demo-build-command` is set to `npm run local-demo`, but that script no longer builds—it only runs `./local-demo.sh`. Since `local-demo:build` was added to run `npm run build && npm run local-demo`, using `npm run local-demo:build` here will ensure the demo always runs against a fresh build instead of stale or missing artifacts.

```suggestion
      demo-build-command: 'npm run local-demo:build'
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown
PR Preview Action f7db5205a15c23aa022c11a68ae8c3039ab4cb71
Preview removed because the pull request was closed.
2026-01-16 23:29 UTC

@rmenner
rmenner merged commit c7958b6 into dev Jan 16, 2026
67 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant