Rmenner/test pr#6
Merged
Merged
Conversation
- Update dev-demo.yml to include publish directory and build command for demo - Remove unused AURO_SURGE_TOKEN from pull-request.yml - Add 'gh-demo' script to package.json for building demo
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub workflows to use the shared dev-demo and pull-request actions with new demo-specific parameters, adjusts local demo npm scripts for more flexible build/zip flows, and tweaks the input component demo title text. Flow diagram for updated local demo npm scriptsflowchart TD
subgraph NPM_Scripts
A[npm run local-demo]
B[npm run local-demo:build]
C[npm run local-demo:zip]
D[npm run build]
E[local-demo_sh]
end
A -->|runs| E
B -->|runs| D
B -->|then runs| A
C -->|runs| B
C -->|forwards --zip to| E
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
.github/workflows/dev-demo.yml, thepull_requesttrigger was removed entirely—if that wasn’t intentional, consider re-adding it or documenting why dev demo runs are no longer needed on PRs. - The new inputs
demo-diranddemo-build-commandin.github/workflows/pull-request.ymlshould be double‑checked against the reusable workflow’s expected input names and semantics to avoid runtime failures. - The change to the input demo page title (
auro-input test) looks like a temporary/testing tweak; consider whether this should be reverted or renamed to something production-appropriate.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `.github/workflows/dev-demo.yml`, the `pull_request` trigger was removed entirely—if that wasn’t intentional, consider re-adding it or documenting why dev demo runs are no longer needed on PRs.
- The new inputs `demo-dir` and `demo-build-command` in `.github/workflows/pull-request.yml` should be double‑checked against the reusable workflow’s expected input names and semantics to avoid runtime failures.
- The change to the input demo page title (`auro-input test`) looks like a temporary/testing tweak; consider whether this should be reverted or renamed to something production-appropriate.
## Individual Comments
### Comment 1
<location> `.github/workflows/pull-request.yml:15` </location>
<code_context>
- component: '["checkbox", "combobox", "counter", "datepicker", "dropdown", "form", "input", "menu", "radio", "select"]'
- is-monorepo: true
+ demo-dir: './auro-formkit-demo'
+ demo-build-command: 'npm run local-demo'
cache-dirs: |
./components/**/dist
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Consider using the new `local-demo:build` script so the demo is built before running
`demo-build-command` is set to `npm run local-demo`, but that script no longer builds—it only runs `./local-demo.sh`. Since `local-demo:build` was added to run `npm run build && npm run local-demo`, using `npm run local-demo:build` here will ensure the demo always runs against a fresh build instead of stale or missing artifacts.
```suggestion
demo-build-command: 'npm run local-demo:build'
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update demo and pull request workflows to use the new local demo build setup for the auro-formkit demo.
Enhancements:
Build:
Documentation: