Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the docs generator to output a Class diagram for updated docs generator member output structureclassDiagram
class Docs {
+generateDocs()
}
class ClassMember {
<<interface>>
}
class ClassMemberOutput {
+parameters Parameter[]
+return string
}
class Parameter {
+name string
+type string
}
Docs --> ClassMember : reads
Docs --> Parameter : uses
Docs --> ClassMemberOutput : maps_to
%% Previous structure (for comparison)
class ClassMemberOutputOld {
+parameters Parameter[]
+returnType string
}
ClassMemberOutputOld <|-- ClassMemberOutput : replaces_returnType_with_return
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Closed
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- This change renames the mapped field from
returnTypetoreturn, so double-check that all downstream consumers (e.g., templates or generators) expectreturnand are updated accordingly to avoid runtime breakage. - Using
returnas an object key can be slightly confusing given the reserved keyword, so consider choosing a more descriptive property name (e.g.,returnTypeorreturnValueType) for clarity.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- This change renames the mapped field from `returnType` to `return`, so double-check that all downstream consumers (e.g., templates or generators) expect `return` and are updated accordingly to avoid runtime breakage.
- Using `return` as an object key can be slightly confusing given the reserved keyword, so consider choosing a more descriptive property name (e.g., `returnType` or `returnValueType`) for clarity.
## Individual Comments
### Comment 1
<location> `src/scripts/docs/docs-generator.ts:149` </location>
<code_context>
...m,
parameters: renderParameters('parameters' in m ? m.parameters as Parameter[] : undefined),
- returnType: 'return' in m && m.return ? getType(m.return) : "",
+ return: 'return' in m && m.return ? getType(m.return) : "",
})),
);
</code_context>
<issue_to_address>
**issue (bug_risk):** Overwriting `m.return` with a string may discard the original return metadata.
This used to add a `returnType` field while preserving `m.return`. Now it overwrites `m.return` with the string from `getType(m.return)`, which may break consumers that rely on `m.return` being the original metadata object. If you only need the type string for templates, consider keeping `returnType` or storing it under a new property and leaving `m.return` unchanged.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
jordanjones243
approved these changes
Jan 2, 2026
Member
|
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Bug Fixes: