(Re-merge): Add filled and outline icons for portable power banks#374
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds two new hazmat power bank icons (filled and stroke variants), registers them in the main icon catalog, and expands the airline tail logo set with new GK, JQ, MX SVGs plus an updated TN tail asset, wired into the logo icon catalog. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The PR title and top-level summary only mention the hazmat power bank icons, but the diff and Sourcery summary also add/update airline tail logo assets; consider updating the title/description or splitting into separate PRs so the scope is clear.
- The description includes two repeated 'Summary by Sourcery' sections with slightly different content; cleaning this up to a single, accurate summary will make the intent of the changes easier to understand for future reviewers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and top-level summary only mention the hazmat power bank icons, but the diff and Sourcery summary also add/update airline tail logo assets; consider updating the title/description or splitting into separate PRs so the scope is clear.
- The description includes two repeated 'Summary by Sourcery' sections with slightly different content; cleaning this up to a single, accurate summary will make the intent of the changes easier to understand for future reviewers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
rmenner
approved these changes
Jul 13, 2026
Member
|
🎉 This PR is included in version 5.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Previously merged in #368. Re-opened due to an NPM publishing key issue.
Summary
Test plan
In demo page:
Summary by Sourcery
Add new hazmat power bank icons and register them in the icon catalog.
New Features:
Enhancements:
Summary by Sourcery
Add new hazmat power bank icons and airline tail logo icons to the icon set.
New Features:
Enhancements: