Skip to content

(Re-merge): Add filled and outline icons for portable power banks#374

Merged
chrisfalaska merged 3 commits into
masterfrom
cfriedberg/power-bank
Jul 13, 2026
Merged

(Re-merge): Add filled and outline icons for portable power banks#374
chrisfalaska merged 3 commits into
masterfrom
cfriedberg/power-bank

Conversation

@chrisfalaska

@chrisfalaska chrisfalaska commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Note: Previously merged in #368. Re-opened due to an NPM publishing key issue.

Summary

  • Add hazmat-power-bank-filled and hazmat-power-bank-stroke icons to the hazmat category
  • Register both in src/data/icons.json, slotted alphabetically between hazmat-oxygen-* and hazmat-small-engine-*

Test plan

In demo page:

Screenshot 2026-07-13 at 10 42 27 AM
  • Verify both icons render in the demo page
  • Confirm color is applied externally (not baked into the SVG) and matches sibling hazmat icons

Summary by Sourcery

Add new hazmat power bank icons and register them in the icon catalog.

New Features:

  • Introduce hazmat-power-bank-filled and hazmat-power-bank-stroke icons in the hazmat icon set.

Enhancements:

  • Update icons.json to include the new hazmat power bank icons in alphabetical order.

Summary by Sourcery

Add new hazmat power bank icons and airline tail logo icons to the icon set.

New Features:

  • Introduce hazmat-power-bank-filled and hazmat-power-bank-stroke icons in the hazmat category.
  • Add new airline tail logo icons for GK, JQ, MX and update the existing TN tail logo entry in the logo set.

Enhancements:

  • Register the new hazmat and tail logo icons in the icons and logoIcons JSON catalogs.

@chrisfalaska chrisfalaska self-assigned this Jul 13, 2026
@chrisfalaska
chrisfalaska marked this pull request as ready for review July 13, 2026 21:09
@chrisfalaska
chrisfalaska requested a review from a team as a code owner July 13, 2026 21:09
@sourcery-ai

sourcery-ai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds two new hazmat power bank icons (filled and stroke variants), registers them in the main icon catalog, and expands the airline tail logo set with new GK, JQ, MX SVGs plus an updated TN tail asset, wired into the logo icon catalog.

File-Level Changes

Change Details Files
Add and register new hazmat power bank filled and stroke icons in the icon set.
  • Create hazmat-power-bank-filled SVG asset matching existing hazmat styling and external color application.
  • Create hazmat-power-bank-stroke SVG asset using outline style consistent with sibling hazmat icons.
  • Register both hazmat power bank icons in icons.json in alphabetical order within the hazmat category.
src/icons/hazmat-power-bank-filled.svg
src/icons/hazmat-power-bank-stroke.svg
src/data/icons.json
Expand and update airline tail logo SVG assets and logo icon catalog.
  • Add new tail logo SVG assets for GK, JQ, and MX airlines following existing tail icon conventions.
  • Update the TN tail logo SVG to the latest artwork while preserving expected viewbox and styling.
  • Register new and updated tail logos in logoIcons.json so they are available through the logo icon catalog.
src/icons/logos/tail-GK.svg
src/icons/logos/tail-JQ.svg
src/icons/logos/tail-MX.svg
src/icons/logos/tail-TN.svg
src/data/logoIcons.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The PR title and top-level summary only mention the hazmat power bank icons, but the diff and Sourcery summary also add/update airline tail logo assets; consider updating the title/description or splitting into separate PRs so the scope is clear.
  • The description includes two repeated 'Summary by Sourcery' sections with slightly different content; cleaning this up to a single, accurate summary will make the intent of the changes easier to understand for future reviewers.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The PR title and top-level summary only mention the hazmat power bank icons, but the diff and Sourcery summary also add/update airline tail logo assets; consider updating the title/description or splitting into separate PRs so the scope is clear.
- The description includes two repeated 'Summary by Sourcery' sections with slightly different content; cleaning this up to a single, accurate summary will make the intent of the changes easier to understand for future reviewers.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chrisfalaska
chrisfalaska merged commit 4e413ae into master Jul 13, 2026
6 checks passed
@chrisfalaska
chrisfalaska deleted the cfriedberg/power-bank branch July 13, 2026 21:21
@blackfalcon

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Completed work has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants