Skip to content

feat: split CSS theme selectors into color and typography groups#465

Merged
jason-capsule42 merged 3 commits into
masterfrom
jbaker/splitTokens
Jul 21, 2026
Merged

feat: split CSS theme selectors into color and typography groups#465
jason-capsule42 merged 3 commits into
masterfrom
jbaker/splitTokens

Conversation

@jason-capsule42

@jason-capsule42 jason-capsule42 commented Jul 21, 2026

Copy link
Copy Markdown
Member

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jason-capsule42 jason-capsule42 self-assigned this Jul 21, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jason-capsule42, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@jason-capsule42
jason-capsule42 requested a review from Copilot July 21, 2026 18:02
@jason-capsule42 jason-capsule42 changed the title feat: split CSS theme selectors into color and typography groups AB#1… feat: split CSS theme selectors into color and typography groups Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the design-tokens CSS build output to support independently applying color vs typography token sets by splitting theme selector blocks into separate groups, while keeping the base theme selector compatible for existing consumers.

Changes:

  • Updated scripts/transformCSS.mjs to classify CSS custom properties into color/typography/other groups and emit separate selector blocks (including new -color and -typography variants).
  • Regenerated dist/web/*.css and dist/themes/CSSCustomProperties--bundled.css outputs to reflect the new selector structure (and corresponding .min.css outputs).
  • Added a post-mortem document describing the breaking change and consumer impact.

Reviewed changes

Copilot reviewed 2 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/transformCSS.mjs Splits extracted CSS custom properties into color/typography/other buckets and rewrites theme selector blocks accordingly.
docs/post-mortem/1601893.md Documents the selector-splitting breaking change and provides migration guidance.
dist/themes/CSSCustomProperties--bundled.css Regenerated bundled theme properties with new color/typography selector variants.
dist/web/alaska.css Regenerated web theme CSS with split selector blocks.
dist/web/alaska.min.css Minified output regenerated to match new selector blocks.
dist/web/atmos.css Regenerated web theme CSS with split selector blocks.
dist/web/atmos.min.css Minified output regenerated to match new selector blocks.
dist/web/hawaiian.css Regenerated web theme CSS with split selector blocks.
dist/web/hawaiian.min.css Minified output regenerated to match new selector blocks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/transformCSS.mjs
Comment thread scripts/transformCSS.mjs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 10 changed files in this pull request and generated 2 comments.

Comment thread scripts/transformCSS.mjs
Comment thread docs/post-mortem/1601893.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

scripts/transformCSS.mjs:205

  • The JSDoc examples use non-existent attributes (data-aag-theme-color / data-aag-theme-typography). The implementation uses a single data-aag-theme attribute and appends -color / -typography to the value (e.g. data-aag-theme="aag-theme-as-color"). This mismatch is likely to confuse future maintainers.
 * For the file's own theme:
 *   :root,
 *   [data-aag-theme="<code>"],
 *   [data-aag-theme-color="<code>"] { ...color vars... }
 *

Comment thread README.md
Comment thread docs/themes.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

scripts/transformCSS.mjs:204

  • The JSDoc selector example uses data-aag-theme-color as a separate attribute, but the implementation (and distributed CSS) uses a single data-aag-theme attribute with the -color suffix appended to the value (e.g. data-aag-theme="aag-theme-as-color"). This doc line should match the actual selector format.
 *   [data-aag-theme-color="<code>"] { ...color vars... }

scripts/transformCSS.mjs:208

  • The JSDoc selector example uses data-aag-theme-typography as a separate attribute, but the implementation uses a single data-aag-theme attribute with -typography appended to the value (e.g. data-aag-theme="aag-theme-as-typography").
 *   [data-aag-theme-typography="<code>"] { ...type vars... }

scripts/transformCSS.mjs:212

  • This JSDoc example uses data-aag-theme-color as a separate attribute for other themes, but the generated selectors are data-aag-theme="<other-code>-color". Updating the example avoids misleading consumers of this script.
 *   [data-aag-theme-color="<other-code>"] { ...color vars... }

scripts/transformCSS.mjs:215

  • This JSDoc example uses data-aag-theme-typography as a separate attribute for other themes, but the generated selectors are data-aag-theme="<other-code>-typography".
 *   [data-aag-theme-typography="<other-code>"] { ...type vars... }

Comment thread README.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated 2 comments.

Comment thread scripts/transformCSS.mjs
Comment thread scripts/transformCSS.mjs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated 2 comments.

Comment thread README.md Outdated
Comment thread docs/themes.md Outdated
sun-mota

This comment was marked as off-topic.

Comment thread docs/post-mortem/1601893.md Outdated
Comment thread docs/post-mortem/1601893.md
Comment thread docs/post-mortem/1601893.md
@sun-mota
sun-mota self-requested a review July 21, 2026 19:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

README.md:56

  • The "Available Themes" table omits the Atmos theme even though the same README immediately documents aag-theme-atm in the "Available theme codes" table. This is inconsistent documentation for consumers; add Atmos to the themes table (or remove it from the codes list if it’s not actually supported).
| Theme | Description | Usage |
|-------|-------------|-------|
| Alaska | Current Alaska Airlines theme | Alaska Airlines branded interfaces |
| Alaska Classic | Transition theme with the latest token names but Auro Classic values | For migration scenarios only |
| Hawaiian | Hawaiian Airlines theme | Hawaiian Airlines branded interfaces |
| Auro Classic | Legacy theme (deprecated) | Only for backward compatibility |

Comment thread docs/themes.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.

Comment thread docs/themes.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 12 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

README.md:56

  • The "Available Themes" table lists Alaska/Alaska Classic/Hawaiian/Auro Classic, but the later "Available theme codes" table includes Atmos (aag-theme-atm). If Atmos is an available theme code, it should also appear in the earlier theme list (or the later list should be scoped/clarified) to avoid conflicting documentation.
|-------|-------------|-------|
| Alaska | Current Alaska Airlines theme | Alaska Airlines branded interfaces |
| Alaska Classic | Transition theme with the latest token names but Auro Classic values | For migration scenarios only |
| Hawaiian | Hawaiian Airlines theme | Hawaiian Airlines branded interfaces |
| Auro Classic | Legacy theme (deprecated) | Only for backward compatibility |

@jason-capsule42
jason-capsule42 marked this pull request as ready for review July 21, 2026 19:19

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jason-capsule42, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Comment thread docs/post-mortem/1601893.md
Comment thread README.md
Comment thread docs/themes.md
Comment thread docs/themes.md
rmenner
rmenner previously approved these changes Jul 21, 2026
@jason-capsule42
jason-capsule42 requested a review from sun-mota July 21, 2026 21:10
@jason-capsule42
jason-capsule42 merged commit 87602de into master Jul 21, 2026
5 checks passed
@jason-capsule42
jason-capsule42 deleted the jbaker/splitTokens branch July 21, 2026 21:11
@blackfalcon

Copy link
Copy Markdown
Member

🎉 This PR is included in version 9.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Completed work has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants