优化代码结构和增强解析能力#72
Open
xiaoyaosharenfan wants to merge 6 commits into
Open
Conversation
Owner
|
I will review it soon. |
Owner
|
感谢这个 PR,里面有一些需求方向是很有价值的,不过目前这版不能直接合并。 主要原因是:
这 7 个需求里,我们可以接受下面这些方向:
下面这些暂时不需要在本 PR 里处理:
建议你把这个 PR 缩小范围,只实现上面可接受的行为增强,并补充对应测试。所有修改应基于最新 master,确保 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.