feat: validate runtime config patching#184
Open
alan-provable wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #163.
Adds
eventLogCapto the writable runtime config surface and rejects unknownPATCH /api/v1/configkeys with a structured400 invalid_requestresponse. This keeps misspelled config names from looking like successful no-op updates while preserving the existing success shape for valid updates.The patch also trims the current in-memory audit log when
eventLogCapis lowered, honors the updated cap for later events, documents the writable config keys in the README, and covers non-integer, zero/negative, and over-limit values.Validation
git diff --check origin/main..HEADnpm run buildnpm run lintnpm testpassed with 95 tests, run with local-listen permission for Supertest ephemeral portsNotes
The route remains an in-memory runtime config API. Unknown keys are rejected atomically before any valid key is applied.