Attribute HITL plan-review requests to SWE-AF via sender manifest#80
Merged
Conversation
SWE-AF created plan-review-v2 HITL requests without a sender, so hax-sdk's
hub rendered them as "Unknown sender". Pass a sender={key, display_name}
defaulting to NODE_ID, overridable via HAX_SENDER_KEY / HAX_SENDER_NAME.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SWE-AF created
plan-review-v2HITL requests through thehaxPython SDK without passing asender, so the hax-sdk hub rendered them as "Unknown sender".This adds a
sendermanifest to the request kwargs inswe_af/app.py(wherehax_create_kwargsis built), attributing the request to the agent node:NODE_ID, defaultswe-planner).HAX_SENDER_KEYandHAX_SENDER_NAME.haxSDK normalizes a plain{key, display_name}dict into the wireSenderManifest, so a dict is sufficient.Scope
Single file, minimal change:
swe_af/app.pyonly.Gates
make check(=pytest tests/ -x -q+compileall swe_af/) run locally on Python 3.12 (matching CI).🤖 Generated with Claude Code