Prevent JS error in an empty cart#68
Open
PromInc wants to merge 3 commits into
Open
Conversation
This is the JS error thrown: "Uncaught TypeError: Cannot read properties of undefined (reading '0')" Steps to recreate: * Visit an empty cart page * Look in the developer tools console tab and notice the error
Bug fix: datepicker doesn't load and thus prevents saving of the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: PR Template
Description
A javascript error is thrown when visiting an empty cart page.
"Uncaught TypeError: Cannot read properties of undefined (reading '0')"
How To Reproduce
Steps to reproduce the behavior:
Expected behavior
No error thrown
Screenshots
Benefits
Reduces white-noise errors that are thrown thus making it easier for developers to focus on errors that matter. Also is good practice to write good code.
Additional information