Skip to content

Fix VLC double-increment on event receive #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ABresting wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix VLC double-increment on event receive #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions consensus/src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,10 @@ impl ConsensusEngine {
/// ensuring proper depth calculation and three-layer storage management.
pub async fn add_event(&self, event: Event) -> SetuResult<EventId> {
// Update local VLC by merging with the event's VLC
// merge() calls VLCSnapshot::receive() which already does merge + increment
{
let mut vlc = self.vlc.write().await;
vlc.merge(&event.vlc_snapshot);
vlc.tick();
}

// Add event through DagManager with retry (handles TOCTOU race with GC)
Expand Down Expand Up @@ -352,10 +352,10 @@ impl ConsensusEngine {
/// Unlike `add_event`, this does not broadcast the event again to avoid message loops.
pub async fn receive_event_from_network(&self, event: Event) -> SetuResult<EventId> {
// Update local VLC by merging with the event's VLC
// merge() calls VLCSnapshot::receive() which already does merge + increment
{
let mut vlc = self.vlc.write().await;
vlc.merge(&event.vlc_snapshot);
vlc.tick();
}

// Add event through DagManager with retry (handles TOCTOU race with GC)
Expand Down