update ksw/cosmo.py/compute_transfer_tensor

[KeyiDing25]

No description provided.

[AdriJD]

This function is not quite correct I think. You can say generally that if the absolute value of m is larger or equal to nell that the returned value should be 0 + 0i. So put that check in before you have the if statements for m >=0 and m < 0. Right now that check is only done for mp and not for m. Also, if (mp >= nell) will never be true because mp is always < 0 I think

So an easier way would be:

Check if abs(m) >= nell: if yes, return 0 + 0i
Check if m >=0
if yes, return a_ell_m[ell * nell + m]
if false, return (m % 2) ? -conjf(a_ell_m[ell * nell + m]) : conjf(a_ell_m[ell * nell + m])

[AdriJD]

please indent the inner parts of for loops. It becomes very hard to see what parts are inside or outside the loop otherwise

so do:

for (ptrdiff_t idx=0; idx<total; idx++){
    out[idx] = 0.f + 0.f * I;
}