fix: dark mode theming, icon/animation polish, and cleanup fixes#123
Conversation
|
@vinodhan07 is attempting to deploy a commit to the Aditya Mahajan's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @Aditya8369 👋 I've fixed this issue — the Community filter tabs and Dashboard/Analytics charts now While testing, I also picked up a few related improvements in the same files:
I opened PR #122 earlier but closed it due to some confusion on my end with the deployment Everything's been tested locally (build passes, no console errors, verified both themes |
|
@vinodhan07 can you tell issue no. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🎉 Your PR just got merged, @vinodhan07 — thank you for contributing to Pollution Control Hub! Your work is now part of the project. Here's what to do next:
We really appreciate you taking the time. See you in the next PR! 🚀 |
Summary
Fixes the dark mode bug where Community filter tabs and Dashboard/Analytics charts stayed
hardcoded to light-theme colors, plus several small improvements/fixes found along the way.
Closes #
1. Dark mode fix (the reported bug)
CommunityHub.jsx: removed inline hardcoded styles on the filter buttons; now driven by.filter-tabs button/.filter-tabs button.activeclasses using the existing themevariables (
--card,--ink,--line,--brand).Dashboard.jsx/AnalyticsInsights.jsx:CartesianGridstroke and axis tick colors nowuse
var(--line)/var(--muted)instead of hardcoded hex, so charts stay legible inboth themes.
Dashboard.jsx'sCustomTooltip, which referenced nonexistent CSS variables(
--bg-card,--text-primary, etc.) and silently fell back to hardcoded light colors.2. Smooth micro-animations
across report cards.
3. Emoji → icon conversion
footer) with
lucide-reacticons for consistent, theme-reactive rendering.4. Small fixes found while testing
HealthAdvisory.jsx: fixed a React key warning —key={section.id}referenced a fieldthat doesn't exist on the
sectionsarray, so every card rendered withkey={undefined}.styles.css: fixed Safari support forbackdrop-filteron the hero eyebrow badge andsticky nav bar (missing/misordered
-webkit-backdrop-filterprefix).Test plan
npm run buildsucceeds with no errorsboth themes, no regression in light mode
including dynamic success/failure states