Skip to content

fix: add dark mode overrides for error banner and location notice#112

Merged
Aditya8369 merged 1 commit into
Aditya8369:mainfrom
Anushkarshetty45:fix/issue-97-dark-mode-banners
Jul 9, 2026
Merged

fix: add dark mode overrides for error banner and location notice#112
Aditya8369 merged 1 commit into
Aditya8369:mainfrom
Anushkarshetty45:fix/issue-97-dark-mode-banners

Conversation

@Anushkarshetty45

Copy link
Copy Markdown
Contributor

Summary

Fixes #97

Added dark mode overrides for .error-banner and .location-notice
in styles.css. Both components used hardcoded light-mode hex colors
with no dark theme fallback, making them unreadable when dark mode is active.

Changes

  • Added [data-theme="dark"] .error-banner override
  • Added [data-theme="dark"] .location-notice override
  • Added [data-theme="dark"] .location-notice button override

Screenshots

Error Banner

Before
WhatsApp Image 2026-07-08 at 23 49 24

After
WhatsApp Image 2026-07-08 at 23 54 11

Location Notice

Before
WhatsApp Image 2026-07-09 at 00 07 12

After
WhatsApp Image 2026-07-09 at 00 05 36

Closes Aditya8369#97

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown

@Anushkarshetty45 is attempting to deploy a commit to the Aditya Mahajan's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pollution-control-hub Ready Ready Preview, Comment Jul 9, 2026 4:55am

@Aditya8369 Aditya8369 added bug Something isn't working ECSoC26 Contributions considered under ECSoC'26 labels Jul 9, 2026
@Aditya8369 Aditya8369 merged commit d47dba5 into Aditya8369:main Jul 9, 2026
3 checks passed
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

🎉 Your PR just got merged, @Anushkarshetty45 — thank you for contributing to Pollution Control Hub!

Your work is now part of the project. Here's what to do next:

  • ⭐ If you haven't already, consider giving the repo a star — it helps us grow.
  • 📢 Share your contribution on LinkedIn, Twitter, or wherever you hang out. You shipped open source!
  • 🔍 Browse other open issues if you want to keep contributing.

We really appreciate you taking the time. See you in the next PR! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ECSoC26-L1 ECSoC26 Contributions considered under ECSoC'26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error banner and location notice use hardcoded light-mode colors - unreadable in dark mode

2 participants