Fix: password-protected easls returning 500 on publish#52
Merged
Conversation
Deploy Previewhttps://preview-pr-52.easl.dev Updated at 2026-07-06T12:35:58.732Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Publishing a password-protected easl — via
--passwordor--generate-password(and the equivalent API/MCP fields) — was failing with a 500 for every user. This restores the feature so password gating works end to end.Why
Password hashing was configured above Cloudflare Workers' hard cap on PBKDF2 iterations, so the hash step threw at runtime and the publish request errored out. The gap wasn't caught because the local test runtime doesn't enforce that cap, so it passed CI while every real publish failed in production. This lowers the iteration count to the platform limit and adds a regression test that pins it, so a future bump can't silently reintroduce the outage. No data migration is needed — no password site was ever successfully stored.