fix: handle EIP-1193 user rejection (code 4001) gracefully during wallet signing [0x954dB727f224dAabeA2A506C8aE92029b25339cE] - #133
Open
waterWang wants to merge 1 commit into
Conversation
…let signing
When a user rejects a transaction signing request in their wallet
(MetaMask/Rabby etc.), the app now shows a neutral info toast
('Transaction cancelled by user') instead of a scary red error toast.
- Add notifyTxCancelled() helper to TxToasts.tsx
- Detect code === 4001 in SendModal's catch block
- Dismiss pending toast for both user rejection and real errors
Closes Adamantine-guild#107
[0x954dB727f224dAabeA2A506C8aE92029b25339cE]
Contributor
|
This PR cannot be merged automatically because it has merge conflicts. Please update the branch with the latest base branch and resolve the conflicts. After the conflicts are resolved and checks pass, the automation can review it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user rejects a transaction signing request in their wallet (MetaMask/Rabby etc.), the app currently shows a scary red error toast with a generic message. This PR handles EIP-1193 error code 4001 (user rejection) gracefully by showing a neutral info toast instead.
Changes
notifyTxCancelled()helper that dismisses the pending toast and shows a neutral info toastcode === 4001and route to the new handlerAcceptance criteria
Closes #107