feat(ui): standardize fiat currency formatting with Intl.NumberFormat - #123
Merged
Lakes41 merged 1 commit intoJul 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces manual string concatenation (e.g.,
"$"+.toFixed()) and ad-hoc formatting helpers with a central, locale-awareformatCurrencyutility powered by the nativeIntl.NumberFormatAPI.Linked Issue
Closes #114
Type of Change
Summary of Changes
src/utils/format.test.ts): Created test coverage verifying grouping separators (commas), edge cases (< $0.01), zero handling, custom currencies, and safe fallbacks fornull/undefined/NaNinputs.components/dashboard/ProtocolStatsBar.tsx): Removed the duplicate inline string formatting function and migrated the component to use the sharedformatCurrencyutility.src/utils/format.ts): Enforced SSR-safe locale detection, strict 2-decimal fiat formatting, and proper number grouping across the application.Test Evidence
Ran local testing suite and TypeScript validation:
npm run lint npm run typecheck npm run test