Unify transaction toast notifications (issue #5) - #120
Merged
Lakes41 merged 1 commit intoJul 30, 2026
Merged
Conversation
- Fix error toasts auto-dismissing; now require manual dismissal per acceptance criteria - Add notifyTxSuccessLocal for success states without a real tx hash - Migrate SwapCard.tsx off raw sonner calls to unified TxToasts helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Transaction toasts (PENDING, SUCCESS, ERROR) were implemented inconsistently across the codebase — some success toasts linked to the block explorer, others didn't; error toasts had inconsistent dismiss behavior; and at least one component (SwapCard.tsx) bypassed the shared toast system entirely with raw sonner calls.
Changes
Notes
Testing