fix: match Zen browser in Firefox web watcher buckets#841
Conversation
Greptile SummaryThis PR fixes Zen Browser URL events being silently dropped from the Browser view when Zen uses the Firefox WebExtension build of
Confidence Score: 5/5A minimal, targeted fix that adds one alternative to an existing regex and a corresponding unit test. No behavioral changes for existing browser types. The change is a single-token addition to an existing regex alternative group. It is verified by a new test, does not touch query generation logic, and Zen's dedicated bucket path remains unaffected. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant WW as Window Watcher
participant ZEN as Zen Browser
participant FB as aw-watcher-web-firefox bucket
participant Q as queries.ts (browserEvents)
ZEN->>FB: URL events (via Firefox WebExtension)
WW->>Q: "window events (app="Zen")"
Note over Q: browsersWithBuckets finds aw-watcher-web-firefox
Q->>Q: "events_firefox = flood(query_bucket(firefox_bucket))"
Q->>Q: "window_firefox = filter_keyvals_regex(events, "app", "(?i)(firefox|...|zen)")"
Note over Q: "Zen" now matches firefox pattern
Q->>Q: "events_firefox = filter_period_intersect(url_events, window_firefox)"
Q-->>Q: Zen URL events correctly attributed
Reviews (1): Last reviewed commit: "fix: match Zen in Firefox web watcher bu..." | Re-trigger Greptile |
Summary
Why
Zen Browser can use the Firefox WebExtension build of aw-watcher-web, which reports URL events into aw-watcher-web-firefox buckets. In that setup the window watcher reports the browser app as
Zen, but the Firefox bucket query only accepted Firefox/LibreWolf/Waterfox/Nightly app names, so Browser view dropped those URL events.Test
npx jest --selectProjects node test/unit/queries.test.node.ts --runInBand