Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/build-tauri.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,19 @@ jobs:
sudo apt-get update
sudo apt-get install -y \
libgtk-3-dev \
libwebkit2gtk-4.1-dev \
libayatana-appindicator3-dev \
librsvg2-dev \
libjavascriptcoregtk-4.1-dev \
libsoup-3.0-dev \
xdg-utils
# Pin WebKit to avoid blank-webview regression on newer ubuntu-24.04 packages
# See: ActivityWatch/aw-tauri#99
sudo apt-get install -y \
libwebkit2gtk-4.1-0=2.44.0-2 \
libwebkit2gtk-4.1-dev=2.44.0-2 \
libjavascriptcoregtk-4.1-0=2.44.0-2 \
libjavascriptcoregtk-4.1-dev=2.44.0-2 \
gir1.2-javascriptcoregtk-4.1=2.44.0-2 \
gir1.2-webkit2-4.1=2.44.0-2
Comment on lines +125 to +131
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 arm64 runner may not resolve version 2.44.0-2

The matrix includes ubuntu-24.04-arm, but the version pin =2.44.0-2 was validated against x86_64 in aw-tauri#99. Ubuntu arm64 packages often carry an ubuntu1 revision suffix (e.g. 2.44.0-2ubuntu1) and may not carry the exact bare 2.44.0-2 version string. If that version isn't present in the arm64 apt sources after apt-get update, every arm Linux build will fail at this step with "Version '2.44.0-2' for 'libwebkit2gtk-4.1-dev' was not found". It's worth confirming the exact available version on ubuntu-24.04-arm (e.g. via apt-cache madison libwebkit2gtk-4.1-dev) before merging.

Comment on lines +125 to +131
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing --allow-downgrades flag

If the ubuntu-24.04 runner image is ever updated to pre-install a newer webkit runtime library (the -0 runtime packages are more likely candidates than the -dev packages), apt-get install with a lower pinned version will fail without --allow-downgrades. Adding the flag makes the pin robust to that scenario.

Suggested change
sudo apt-get install -y \
libwebkit2gtk-4.1-0=2.44.0-2 \
libwebkit2gtk-4.1-dev=2.44.0-2 \
libjavascriptcoregtk-4.1-0=2.44.0-2 \
libjavascriptcoregtk-4.1-dev=2.44.0-2 \
gir1.2-javascriptcoregtk-4.1=2.44.0-2 \
gir1.2-webkit2-4.1=2.44.0-2
sudo apt-get install -y --allow-downgrades \
libwebkit2gtk-4.1-0=2.44.0-2 \
libwebkit2gtk-4.1-dev=2.44.0-2 \
libjavascriptcoregtk-4.1-0=2.44.0-2 \
libjavascriptcoregtk-4.1-dev=2.44.0-2 \
gir1.2-javascriptcoregtk-4.1=2.44.0-2 \
gir1.2-webkit2-4.1=2.44.0-2


- name: Install dependencies
run: |
Expand Down
Loading