-
-
Notifications
You must be signed in to change notification settings - Fork 909
fix(ci): pin WebKit to 2.44.0-2 to fix blank-webview regression in Linux builds #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -116,12 +116,19 @@ jobs: | |||||||||||||||||||||||||||||
| sudo apt-get update | ||||||||||||||||||||||||||||||
| sudo apt-get install -y \ | ||||||||||||||||||||||||||||||
| libgtk-3-dev \ | ||||||||||||||||||||||||||||||
| libwebkit2gtk-4.1-dev \ | ||||||||||||||||||||||||||||||
| libayatana-appindicator3-dev \ | ||||||||||||||||||||||||||||||
| librsvg2-dev \ | ||||||||||||||||||||||||||||||
| libjavascriptcoregtk-4.1-dev \ | ||||||||||||||||||||||||||||||
| libsoup-3.0-dev \ | ||||||||||||||||||||||||||||||
| xdg-utils | ||||||||||||||||||||||||||||||
| # Pin WebKit to avoid blank-webview regression on newer ubuntu-24.04 packages | ||||||||||||||||||||||||||||||
| # See: ActivityWatch/aw-tauri#99 | ||||||||||||||||||||||||||||||
| sudo apt-get install -y \ | ||||||||||||||||||||||||||||||
| libwebkit2gtk-4.1-0=2.44.0-2 \ | ||||||||||||||||||||||||||||||
| libwebkit2gtk-4.1-dev=2.44.0-2 \ | ||||||||||||||||||||||||||||||
| libjavascriptcoregtk-4.1-0=2.44.0-2 \ | ||||||||||||||||||||||||||||||
| libjavascriptcoregtk-4.1-dev=2.44.0-2 \ | ||||||||||||||||||||||||||||||
| gir1.2-javascriptcoregtk-4.1=2.44.0-2 \ | ||||||||||||||||||||||||||||||
| gir1.2-webkit2-4.1=2.44.0-2 | ||||||||||||||||||||||||||||||
|
Comment on lines
+125
to
+131
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If the
Suggested change
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| - name: Install dependencies | ||||||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.44.0-2The matrix includes
ubuntu-24.04-arm, but the version pin=2.44.0-2was validated against x86_64 in aw-tauri#99. Ubuntu arm64 packages often carry anubuntu1revision suffix (e.g.2.44.0-2ubuntu1) and may not carry the exact bare2.44.0-2version string. If that version isn't present in the arm64 apt sources afterapt-get update, every arm Linux build will fail at this step with "Version '2.44.0-2' for 'libwebkit2gtk-4.1-dev' was not found". It's worth confirming the exact available version onubuntu-24.04-arm(e.g. viaapt-cache madison libwebkit2gtk-4.1-dev) before merging.