Skip to content

ci: fix latest-TypeScript typings gate (TS 7 removed moduleResolution=node) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Acro merged 1 commit into from
Jul 12, 2026
Merged

ci: fix latest-TypeScript typings gate (TS 7 removed moduleResolution=node) #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ jobs:
npm install --no-save typescript@3.4.5
./node_modules/.bin/tsc --noEmit --strict --target es2017 --lib es2017 --moduleResolution node consumer.ts
- name: Typings gate — latest TypeScript compiles the installed d.ts
# node16 resolution (not the removed-in-TS7 `node`/node10) — this also
# exercises the exports map's `import`/`require` type conditions.
run: |
cd /tmp/consumer
npm install --no-save typescript@latest
./node_modules/.bin/tsc --noEmit --strict --target es2017 --lib es2017 --moduleResolution node consumer.ts
./node_modules/.bin/tsc --noEmit --strict --target es2017 --lib es2017 --module node16 --moduleResolution node16 consumer.ts
Loading