Skip to content

fix: Watch the IsEnabled property to lazily activate on Unix#715

Open
DataTriny wants to merge 1 commit into
mainfrom
unix-lazy-init-switch-prop
Open

fix: Watch the IsEnabled property to lazily activate on Unix#715
DataTriny wants to merge 1 commit into
mainfrom
unix-lazy-init-switch-prop

Conversation

@DataTriny
Copy link
Copy Markdown
Member

Closes #713

Following this commit in at-spi2-core we need to stop relying on the now removed ScreenReaderEnabled bus property and switched to monitor IsEnabled instead, which should be more reliable.

@DataTriny
Copy link
Copy Markdown
Member Author

I'm not currently able to validate this on a Freedesktop environment.

@RastislavKish it would be great if you could apply lazy-activation-debug.patch on top of this branch then try the simple winit example. Let me know if the tree gets initialized immediately when Orca was previously running, if it can be first initialized later if Orca is not initially running and if it can be deactivated and reactivated during the app lifecycle.

Thank you for your help.

@RastislavKish
Copy link
Copy Markdown

@DataTriny looks good! I have installed at-spi-2-core from source and things seem to be working well, I can see both activation and deactivation reports as I turn on / off the screenreader. Everything also works as expected regardless when the screenreader is started i.e. before or after launching the app. Great work on both your and Mike's side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AccessKit no longer detects when Orca is running

2 participants