Skip to content

Update DCO Checker script link#1383

Open
matthewlow-dwa wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
matthewlow-dwa:patch-1
Open

Update DCO Checker script link#1383
matthewlow-dwa wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
matthewlow-dwa:patch-1

Conversation

@matthewlow-dwa

Copy link
Copy Markdown
Contributor

Updates the DCO Checker script link on the Contribution Guidelines page. The old repo link has been deprecated in favor of the newer repository.

Signed-off-by: Matthew Low <72585572+matthewlow-dwa@users.noreply.github.com>
@jfpanisset

Copy link
Copy Markdown
Contributor

@jmertic Should this script / repo be "vendored" into the ASWF Org repo?

@jfpanisset jfpanisset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps consider if ASWF org should perhaps have its own fork of that repo?

@jmertic

jmertic commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

I don't see a need to vendor/fork this repo @jfpanisset - are you seeing a use case for doing that?

@jfpanisset

Copy link
Copy Markdown
Contributor

Of course we all know you, but as a general rule, isn't it preferable for project to avoid dependencies in their CI to repos from individual GitHub accounts?

This particular PR doesn't change this situation, it just fixes a broken link, but more generally perhaps the DCO tooling should live under the LF GitHub org?

@jmertic

jmertic commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@jfpanisset I would say in general, forks are a anti-pattern. Pinning dependencies is a good practice, but here this is just a tool to use and not a dependency per se.

As for the tooling under the LF, it's not really maintained by the LF officially, just me right now. But maybe that is something to review for us internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants