fix: SG-43602: Fix crash when adding a session file alongside media files#1294
Open
markreidvfx wants to merge 1 commit into
Open
Conversation
When addSources received a single .rv session file mixed with one or more media files, the merge flag was not set because the check required rvFileCount > 1. Without merge mode the session file and media files are loaded into the same graph concurrently, leading to memory corruption and crashes. Change the condition to trigger merge when any .rv file is present alongside other inputs. Signed-off-by: Mark Reid <markreid@netflixanimation.com>
markreidvfx
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
bernie-laberge
changed the title
bernie-laberge
added
PR: Acknowledged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
N/A
Summarize your change.
Fix a crash when loading an
.rvsession file alongside media files. A single session file mixed with media was not triggering merge mode, so the session import would overwrite the graph while media files were still being loaded, causing memory corruption.Describe what you have tested and on which operating system.
Tested on Rocky Linux 9.
To reproduce on unpatched OpenRV:
The crash is more likely when the session file is the last argument or in the middle of multiple files.
If possible, provide screenshots.
N/A