fix: SG-43328: Annotation drawing not always updated in Stereo mode#1278
Open
deltag0 wants to merge 4 commits into
Open
fix: SG-43328: Annotation drawing not always updated in Stereo mode#1278deltag0 wants to merge 4 commits into
deltag0 wants to merge 4 commits into
Conversation
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
deltag0
changed the title
deltag0
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
| // Recursively stamps the eye's paint target region on every IPImage in | ||
| // the subtree so the renderer can find it on whichever descendant | ||
| // actually carries the paint commands. (might not be needed) | ||
| void propagatePaintRegion(IPImage* img, float rx, float ry, float rw, float rh) |
Contributor
There was a problem hiding this comment.
You wrote "might not be needed" in the comment above this function, but it's being called in prepareForStereo. Is it needed or not to fix the issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Annotation drawing not always updated in Stereo mode
Summarize your change.
Previously, when annotating in stereo mode with multiple eyes (buffers), the right side would look frozen. The caching logic was sound, but wasn't considering that rendering in 2 passes caused the right side to reset because the cache of the eye rendering second was holding stale data since the code was caching the entire view even when there were 2 eyes.
So, now, when we have multiple views we cache only the relevant part to avoid clobbering/stale data.
Describe the reason for the change.
Not cool that annotations don't update at the same time for each eye.
Describe what you have tested and on which operating system.
Mac CY2025
Add a list of changes, and note any that might need special attention during the review.