Add hotkey to group nodes into a node graph#3002
Conversation
|
This looks very promising, thanks @minhpham1810, and take a look at the comment above for instructions on resolving the EasyCLA errors. |
7a4a73e to
027125f
Compare
027125f to
c344edb
Compare
|
@jstone-lucasfilm I just signed the CLA and changed my commit email, please have a look. |
|
Thanks for the excellent work here, @minhpham1810. The connection-preservation logic is more thorough than I'd expected, and the hard parts are done well. This PR has grown into something larger than the summary suggests, though, so before we dive into code review I'd like to align on scope. Two recommended next steps would be:
Once we've settled the scope, I'm glad to go deep on the grouping logic itself. Thanks again for the strong contribution! |
|
@jstone-lucasfilm Thank you so much for the detailed feedback! I admitted that I want a bit out of scope in this PR, so I reverted the changes I made in |
Summary
Adds the MaterialX Graph Editor
Shift+Cnode-grouping shortcut so it actually triggers when graph nodes are selected.When graph nodes are selected, the shortcut creates a new nodegraph, moves the selected nodes into it, and preserves relevant boundary connections so the resulting nodegraph remains usable without manually reconnecting links.
Changes
Shift+Chandling for grouping selected Graph Editor nodes into a nodegraph.MaterialXTestcoverage for the grouping shortcut state.Scope Note
This PR currently includes support for grouping within nested nodegraphs, which required changes in
MaterialXCoreconnection resolution. Based on maintainer feedback, I’m happy to narrow this PR to top-level document grouping only and move nested nodegraph support into a follow-up PR. (This feature is currently limited, now nodes can only be grouped at the top level of the document.)Testing
git diff --checkMaterialXTest "Graph editor grouping shortcut"cmake --build build --target MaterialXGraphEditorRelated Issue
Fixes #2018