refactor(codebase): code conventions alignment - #9
Merged
Conversation
Rename files and directories following the Code Conventions specified in the ./docs/ code_conventions.md file.
Reorganize imports according to the Code Conventions defined in the ./docs/code_conventions.md file
Refactor the type's value of "not available" to "not_available" accroding to he Code Conventions defined in the `./docs/code_conventions.md` file.
As it require the Code Conventions specified in the `./docs/code_conventions.md` file
Remove all `console.log` as it require the Code Conventions specified in the `./docs/code_conventions.md` file.
- remove `export` keyword from each interface which is not used outside the fire it resides. - extract non-UI related interfaces and move to `lib/types.ts` like BreadcrumbsItemType and CommentCardType
- remove unused params, variables, and interfaces
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to refactor the existing codebase to apply all the Code Conventions.
Changes
snake_caseaccording to the Code Conventions - File Architecture section.AvailabilityType's value of "not available" to "not_available" accroding to he Code Conventions - Types section.console.logas it require the Code Conventions - console.log Policy section.exportkeyword from each interface which is not used outside the fire it resides.lib/types.tslike BreadcrumbsItemType and CommentCardType.Testing
Checklist