fix: patch 10 bugs across brief pipeline, extension workers, and token/DB safety#19
Merged
Merged
Conversation
…n/DB safety
Backend:
- crypto.py: return None (not the raw enc:v1: string) on InvalidToken so callers
know decryption failed instead of forwarding garbage to OnTrack
- db.py: null-guard fetchone()[0] in upsert_user for both PG and SQLite paths
- jobs.py: wrap run_brief() in top-level try/except so APScheduler never swallows
a silent crash; check and log send_brief_to / send_briefs_enabled_email return values
- renderer.py: set stamp="recently" on ValueError instead of embedding raw DB string in HTML
- builder.py: add logging, use .get("project_id") with null guard, log bad deadlines
- routes/main.py: use r.get() for deadline/project_id in snapshot endpoint to avoid KeyError
Extension:
- background.js: move lastIngestHash.set() into the fetch .then() success handler so a
failed push is never silently deduped on retry; promisify chrome.storage.local.get
in the cookie handler for MV3 service-worker safety
- injected.js: remove stale request-header token fallback in XHR load handler (was
rolling back lastToken to an older value on concurrent requests); add deferred sweep
so sweepProjectTasks() fires once the first token arrives even if /api/projects
was intercepted before any auth token was captured
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F5KBH3tzb533sA4LxLYMUp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Type of change
Checklist
mainruff check .passespytestpasses (if backend changes)npm run lintpasses inextension/(if extension changes).envfiles, tokens, or database filesNotes for reviewers