fix: enforce one OnTrack login per account on link#18
Merged
Conversation
Two Clerk accounts linking the same OnTrack username created duplicate user rows (username isn't a unique key). /ingest resolves by username alone, so it could write captured tasks to the wrong row, while /api/snapshot — resolved by Clerk id — read the other and showed nothing. On /link-ontrack, after the account's row is established, evict any other rows holding the same username (and their captured tasks/projects), dropping their orphaned brief jobs. Last verified OnTrack linker wins; idempotent once a single row remains, so it also self-heals existing duplicates on next popup open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Clerk accounts linking the same OnTrack username created duplicate user rows (username isn't a unique key). /ingest resolves by username alone, so it could write captured tasks to the wrong row, while /api/snapshot — resolved by Clerk id — read the other and showed nothing.
On /link-ontrack, after the account's row is established, evict any other rows holding the same username (and their captured tasks/projects), dropping their orphaned brief jobs. Last verified OnTrack linker wins; idempotent once a single row remains, so it also self-heals existing duplicates on next popup open.
Summary
Related issue
Type of change
Checklist
mainruff check .passespytestpasses (if backend changes)npm run lintpasses inextension/(if extension changes).envfiles, tokens, or database filesNotes for reviewers