Skip to content

Dual ported RAM fix #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamedleithy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dual ported RAM fix #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b55d587
dual ported ram fix
mohamedleithy Jun 2, 2023
94c3736
Enable some test designs
donn Jun 4, 2023
04d1665
Merge branch 'main' into dual-ported-ram-fix
donn Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,19 @@ jobs:
matrix:
include:
- { count: "32", width: "8", variant: "DEFAULT" }
# - { count: "32", width: "8", variant: "1RW1R" }
- { count: "32", width: "8", variant: "1RW1R" }
- { count: "32", width: "16", variant: "DEFAULT" }
# - { count: "32", width: "16", variant: "1RW1R" }
- { count: "32", width: "16", variant: "1RW1R" }
- { count: "32", width: "32", variant: "DEFAULT" }
# - { count: "32", width: "32", variant: "1RW1R" } # Timeout
- { count: "32", width: "32", variant: "2R1W" }
- { count: "128", width: "32", variant: "DEFAULT" }
- { count: "256", width: "8", variant: "DEFAULT" }
# - { count: "256", width: "8", variant: "1RW1R" }
- { count: "256", width: "8", variant: "1RW1R" }
- { count: "256", width: "16", variant: "DEFAULT" }
# - { count: "256", width: "16", variant: "1RW1R" } # Timeout
- { count: "256", width: "32", variant: "DEFAULT" }
#- { count: "256", width: "32", variant: "1RW1R" } # Timeout
# - { count: "256", width: "32", variant: "1RW1R" } # Timeout
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@ support/
*.cvcrc
*.xz
venv/
products_path
/products_path
/products
/products
6 changes: 3 additions & 3 deletions dffram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ def run(self, state_in, **kwargs):
kwargs, env = self.extract_env(kwargs)

env["DIE_AREA"] = f"0 0 {die_width} {die_height}"
env[
"CORE_AREA"
] = f"{horizontal_halo} {vertical_halo} {horizontal_halo + core_width} {vertical_halo + core_height}"
env["CORE_AREA"] = (
f"{horizontal_halo} {vertical_halo} {horizontal_halo + core_width} {vertical_halo + core_height}"
)
env["FP_SIZING"] = "absolute"
return super().run(state_in, env=env, **kwargs)

Expand Down
2 changes: 1 addition & 1 deletion models/ram/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ counts: [8, 32, 128, 256, 512, 1024, 2048]
design_name_template: "RAM{count}{variant}"
variants:
- null
# - "1RW1R"
- "1RW1R"
3 changes: 2 additions & 1 deletion placeram/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ def lrplace(
elements: Union[List[Instance], Instance] = getattr(self, accessor)
if len(elements) == 0:
continue
element = elements[i]
if i < len(elements):
element = elements[i]
if isinstance(element, list):
column += element
else:
Expand Down