Skip to content

[Chore/#112] kakao key 추가#115

Open
taegeon2 wants to merge 7 commits into
developfrom
chore/#112-kakao-key
Open

[Chore/#112] kakao key 추가#115
taegeon2 wants to merge 7 commits into
developfrom
chore/#112-kakao-key

Conversation

@taegeon2

Copy link
Copy Markdown
Contributor

📝 요약

  • .env.example에 카카오 JS 키 항목을 추가했습니다.

⚙️ 작업 내용

  • .env.example에 EXPO_PUBLIC_KAKAO_JS_KEY 항목 추가

🔗 관련 이슈

✅ 체크리스트

  • 코딩 컨벤션(Biome/Lint)을 준수하였습니다.
  • 모든 타입 에러를 해결하였습니다. (Typecheck)
  • 변경 사항에 대한 테스트를 마쳤습니다.
  • 불필요한 로그(console.log)를 제거하였습니다.

💬 리뷰어에게

@taegeon2 taegeon2 self-assigned this May 25, 2026
@github-actions github-actions Bot added the chore 버전 코드 수정, 패키지 구조 변경 등 작은 작업 label May 25, 2026
@github-actions

Copy link
Copy Markdown

Thanks for the contribution!
I have applied any labels matching special text in your title and description.

Please review the labels and make any necessary changes.

@taegeon2 taegeon2 changed the title Chore/#112 kakao key [Chore/#112] kakao key May 25, 2026
@taegeon2 taegeon2 changed the title [Chore/#112] kakao key [Chore/#112] kakao key 추가 May 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements Kakao Maps integration using react-native-webview and expo-location, featuring a custom map component and a location-tracking hook. The reviewer identified a race condition in the location hook's cleanup and recommended moving business logic from the widget layer to higher-level layers to improve architectural separation. Other feedback includes optimizing performance by preventing unnecessary WebView reloads when coordinates change, adding defensive checks for environment variables, and improving error logging for communication between the WebView and the native application.

Comment thread src/widgets/map/model/useUserLocation.ts
Comment thread src/shared/ui/kakao-map/KakaoMap.tsx Outdated
Comment thread src/shared/ui/kakao-map/KakaoMap.tsx Outdated
Comment thread src/shared/ui/kakao-map/KakaoMap.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore 버전 코드 수정, 패키지 구조 변경 등 작은 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant