deploy: ship noc-agent traces to agent-core collector

[Svaag]

Summary

• pin noc-agent to trace: emit agent-core events from NOC graph noc-agent#61 merge commit with agent-core trace emission
• enable the NOC trace sink toward the loop collector
• render the trace env vars in both Vault Agent and legacy env backends
• add an IaC regression test for the NOC trace env contract

Validation

• pytest tests/iac/test_vault_and_runner_contracts.py tests/iac/test_app_version_pins.py
• git diff --check
• cd ansible && ansible-playbook playbooks/noc.yml --syntax-check

Part of agent-core trace pipeline rollout step 11.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌ 61 - Not compliant Non-compliant requirements: This PR does not modify vault-agent.service.j2 This PR does not add any ExecStartPre looping over vault_agent_extra_dirs The vault-agent unit template is not touched

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 95

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Wrap URL variable in quotes The collector URL is not wrapped in quotes, which could cause parsing issues if the URL contains special characters or spaces. Wrap the variable in double quotes to ensure safe interpolation. ansible/roles/vault_agent/templates/noc-agent.env.ctmpl.j2 [76] -HYRULE_NOC_AGENT_CORE_TRACE_COLLECTOR_URL={{ noc_agent_core_trace_collector_url }} +HYRULE_NOC_AGENT_CORE_TRACE_COLLECTOR_URL="{{ noc_agent_core_trace_collector_url }}" Suggestion importance[1-10]: 6 __ Why: Wrapping the URL variable in double quotes prevents potential parsing issues if the URL contains special characters; it's a minor but valid improvement for robustness.	Low

[Svaag]

Addressed the PR-agent URL quoting suggestion in b634427 by quoting HYRULE_NOC_AGENT_CORE_TRACE_COLLECTOR_URL in both the Vault Agent template and the legacy env backend.

The ticket compliance note for network-operations #61 is a false association from the cross-repo AS215932/noc-agent#61 reference. This PR is not intended to close network-operations #61; it deploys the noc-agent trace emitter merge commit and enables collector shipping for rollout step 11.

Validation after the fix: pytest tests/iac/test_vault_and_runner_contracts.py tests/iac/test_app_version_pins.py, git diff --check, and cd ansible && ansible-playbook playbooks/noc.yml --syntax-check.

[Svaag]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: b6344277b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".