Add :snake_number - #39
Draft
AS1100K wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR adds a new :snake_number modifier to the pastey segment modifier pipeline to produce snake_case output that separates embedded numbers (e.g., ThisIsButA1Test → this_is_but_a_1_test), addressing feature request #38.
Changes:
- Extend the
:snakemodifier logic to support a new:snake_numbervariant that can underscore before numeric runs. - Add test coverage for
:snake_number(including:lower/:upper) in the test suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/segment.rs | Adds snake_number handling to snake-case conversion logic. |
| pastey-test-suite/tests/test_item.rs | Adds tests validating snake_number output (and lower/upper variants). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+156
to
+164
| m!(ThisIsButA1Test); | ||
|
|
||
| #[test] | ||
| fn test_to_snake_number() { | ||
| assert_eq!(DEFAULT_SNAKE_NUMBER, "this_is_but_a_1_test"); | ||
| assert_eq!(LOWER_SNAKE_NUMBER, "this_is_but_a_1_test"); | ||
| assert_eq!(UPPER_SNAKE_NUMBER, "THIS_IS_BUT_A_1_TEST"); | ||
| } | ||
| } |
Comment on lines
+216
to
+217
| let should_trigger_underscore = | ||
| ch.is_uppercase() || (include_numbers && ch.is_numeric()); |
AS1100K
marked this pull request as draft
July 1, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38