Replace STD to CORE lib by bharatGoswami8 · Pull Request #37 · AS1100K/pastey

bharatGoswami8 · 2026-05-22T04:35:57Z

Change most possible import from std to core
Updated alternative solution

codecov-commenter · 2026-05-22T04:37:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

bharatGoswami8 · 2026-05-22T05:13:15Z

@AS1100K, could you please review this PR.

bharatGoswami8 · 2026-05-25T03:20:54Z

@AS1100K, could you please review this PR.

bharatGoswami8 · 2026-05-26T03:39:42Z

@AS1100K, could you please review this PR.

bharatGoswami8 · 2026-05-28T04:20:58Z

@AS1100K , could you please review this PR.

bharatGoswami8 · 2026-06-01T04:37:32Z

@AS1100K , could you please review this PR.

Copilot

Pull request overview

This PR aims to reduce reliance on std by switching many imports to core, while also adjusting token construction logic in the proc-macro implementation and tightening CI coverage enforcement.

Changes:

Replaced several std::* imports with core::* equivalents across the crate.
Updated pasted_to_tokens identifier handling and added additional invalid-identifier test cases (including a new compile-fail doctest).
Added a CI step to print coverage summary and enforce 100% line/region coverage thresholds.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/test_helpers.rs`	Switches `FromStr` import from `std` to `core` in internal proc-macro test helpers.
`src/segment.rs`	Switches `Peekable` import from `std` to `core`.
`src/lib.rs`	Switches common imports to `core`, modifies identifier/literal token creation logic, and adds additional tests/doctests for invalid paste inputs.
`src/error.rs`	Switches iterator/result type references from `std` to `core`.
`src/attr.rs`	Switches `iter`, `mem`, and `FromStr` imports from `std` to `core`.
`.github/workflows/ci.yml`	Adds an extra `llvm-cov` step to print coverage summary and enforce coverage thresholds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AS1100K · 2026-06-03T08:39:25Z

+    // Justification for not catching panics from Ident::new/Ident::new_raw:
+    // After basic validation above, these functions might still panic for edge cases
+    // (e.g., keywords without raw mode, Unicode edge cases). If we reach this point
+    // with such input, it indicates a bug in our paste logic (segment parsing,
+    // modifier handling, or concatenation). Letting it panic surfaces these bugs
+    // during development/testing. The proc_macro validation is comprehensive and
+    // handles Unicode, keywords, and other edge cases correctly.
+    let ident = if raw_mode {
+        let mut spasted = pasted.clone();
+        spasted.remove(0);
+        spasted.remove(0);
+        TokenTree::Ident(Ident::new_raw(&spasted, span))
+    } else {
+        TokenTree::Ident(Ident::new(&pasted, span))
    };


Maybe just Revert this change

Any alternative can you suggest, i want to remove the dependency of std most of the possible place.

@AS1100K , Could you please check once the updated commit / solution, now we are doing error handing for those cases rather than panic.

AS1100K

Thanks @bharatGoswami8 for working on this!

I'm sorry that it took so long to review this PR as my university exams were going on during that time, and I didn't found any time looking into the PRs

AS1100K · 2026-06-03T08:38:40Z

      - run: cargo +nightly llvm-cov --workspace --branch --exclude-from-report pastey-test-suite --doctests --lcov --output-path lcov.info
        env:
          RUSTFLAGS: -C instrument-coverage -C llvm-args=-pgo-warn-missing-function
+      - name: Print coverage summary and thresould check
+        run: cargo +nightly llvm-cov --workspace --branch --exclude-from-report pastey-test-suite --doctests --fail-under-lines 100 --fail-under-regions 100
+        env:
+          RUSTFLAGS: -C instrument-coverage -C llvm-args=-pgo-warn-missing-function


Can't we just keep the single run command instead of similar two run commands, so that in future it eliminates the chances of the commands not synced

no i think because the above one is storing the result in lcov.info which we can not print directly on CI.

AS1100K · 2026-06-03T08:39:25Z

+    // Justification for not catching panics from Ident::new/Ident::new_raw:
+    // After basic validation above, these functions might still panic for edge cases
+    // (e.g., keywords without raw mode, Unicode edge cases). If we reach this point
+    // with such input, it indicates a bug in our paste logic (segment parsing,
+    // modifier handling, or concatenation). Letting it panic surfaces these bugs
+    // during development/testing. The proc_macro validation is comprehensive and
+    // handles Unicode, keywords, and other edge cases correctly.
+    let ident = if raw_mode {
+        let mut spasted = pasted.clone();
+        spasted.remove(0);
+        spasted.remove(0);
+        TokenTree::Ident(Ident::new_raw(&spasted, span))
+    } else {
+        TokenTree::Ident(Ident::new(&pasted, span))
    };


Maybe just Revert this change

AS1100K · 2026-06-09T10:23:51Z

@bharatGoswami8 Why do we need we need the crate to shift away from using std to core. I don't see any benefit here, as this isn't going to benefit anyway as the proc-macro crates run on the host machine and the proc-macro using std will also work with crates #![no_std]

https://www.reddit.com/r/rust/comments/9lu9xo/can_a_no_std_crate_depend_on_a_procmacro_crate/

* Change most possible import from std to core * Updated alternative solution

bharatGoswami8 · 2026-06-09T10:50:28Z

@bharatGoswami8 Why do we need we need the crate to shift away from using std to core. I don't see any benefit here, as this isn't going to benefit anyway as the proc-macro crates run on the host machine and the proc-macro using std will also work with crates #![no_std]

https://www.reddit.com/r/rust/comments/9lu9xo/can_a_no_std_crate_depend_on_a_esprocmacro_crate/

Hi @AS1100K ,
When we use some safety qualified compiler and, in those cases, we do need to use the dependency which is already qualified and std still not safety qualified yet, but core lib is partially qualified.

I have reverted major changes related catch_unwind, now only we are using the alternative of std from core.

bharatGoswami8 · 2026-06-16T08:38:30Z

@AS1100K, could you please review this PR.

bharatGoswami8 · 2026-06-19T14:04:55Z

@AS1100K, could you please review this PR and merge it.

bharatGoswami8 force-pushed the std_to_core branch 6 times, most recently from 28df195 to d013dd5 Compare May 22, 2026 05:11

bharatGoswami8 marked this pull request as ready for review May 22, 2026 05:11

AS1100K requested a review from Copilot June 3, 2026 08:18

Copilot started reviewing on behalf of AS1100K June 3, 2026 08:18 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

AS1100K requested changes Jun 3, 2026

View reviewed changes

bharatGoswami8 requested a review from AS1100K June 3, 2026 16:43

Replace STD to CORE lib

7e748d7

* Change most possible import from std to core * Updated alternative solution

bharatGoswami8 force-pushed the std_to_core branch from 7fadeb2 to 7e748d7 Compare June 9, 2026 10:44

Uh oh!

Conversation

bharatGoswami8 commented May 22, 2026

Uh oh!

codecov-commenter commented May 22, 2026 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bharatGoswami8 commented May 22, 2026

Uh oh!

bharatGoswami8 commented May 25, 2026

Uh oh!

bharatGoswami8 commented May 26, 2026

Uh oh!

bharatGoswami8 commented May 28, 2026

Uh oh!

bharatGoswami8 commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

AS1100K Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AS1100K left a comment

Choose a reason for hiding this comment

Uh oh!

AS1100K Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

AS1100K Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

AS1100K commented Jun 9, 2026

Uh oh!

bharatGoswami8 commented Jun 9, 2026

Uh oh!

bharatGoswami8 commented Jun 16, 2026

Uh oh!

bharatGoswami8 commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented May 22, 2026 •

edited by codecov Bot

Loading

bharatGoswami8 Jun 3, 2026 •

edited

Loading