CI Workflow Refactor#96
Merged
Merged
Conversation
Signed-off-by: Tarek <tareknaser360@gmail.com>
…cess Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
pushkarm029
reviewed
Dec 27, 2024
oluiscabral
added a commit
that referenced
this pull request
Jun 10, 2025
* Build and release `fs-storage` JNI libraries and publish Java library * Create `cache.yml` workflow * WIP - start transforming it into AAR * WIP - set up library as AAR * Finish AAR setup * Set up NDK to GitHub Actions * Fix `Set up NDK` step * Set up Android SDK * Set `ANDROID_NDK_HOME` env var * Set specific ndk version * Fix NDK version * Bring back Android SDK setup * Final touches on AAR build and release workflow * Fix: speedup `build.yml` and add targets to `release.yml` * Define `GITHUB_ACTOR` as well * Wrap GitHubPackages URI in `uri(string)` * Copy old `publications` From: https://github.com/ARK-Builders/ark-core/blob/23567aeb6b1184cd004ab7419b8e1895be618024/java/lib/build.gradle.kts * Update permissions and publications * Use tag name as version and clean publication * Remove local configuration * add `rustfmt` formatting check * Try using regex as released tag evaluator * Try new release regex condition * Fix: Properly remove first character of released tag * Fix: Try using `GITHUB_REF_NAME` to remove first char of released tag * Fix: export `RELEASE_VERSION` instead of setting it as `env` in yml * Update Android NDK and `java/README.md` instructions * CI Workflow Refactor (#96) * refactor(CI): move Java bindings into a separate job * chore(CI): remove old benchmark workflow and integrate into build process * refactor(CI): consolidate OS jobs into a single build-and-test job --- Signed-off-by: Tarek <tareknaser360@gmail.com> --------- Signed-off-by: Tarek <tareknaser360@gmail.com> Co-authored-by: Tarek Elsayed <60650661+tareknaser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the CI workflows. The biggest change is moving Java bindings to a separate job that only runs if the "Build and Test" jobs pass.
Related discussion: #94 (comment)
What’s New:
Why This Approach?
workflow_run, but ran into issues with getting thebranchNameand commenting on PRs.Current CI Setup:
Examples from my fork:
Run Example
Run Example