Docs/update readme v0.3.0#5
Conversation
…and risk scoring - Add network_findings.py: flags risky listening ports (RDP, Telnet, FTP, VNC, etc.) - Add processes.py collector + process_findings.py: audits privileged processes (SYSTEM/root) - Add disk_encryption.py collector + disk_encryption_findings.py: checks BitLocker, FileVault, and LUKS status - Add scoring.py: calculates a 0-100 risk score from findings severity with labeled ratings - Wire all new collectors and findings into main.py audit pipeline - Update markdown_report.py with Process Audit, Disk Encryption, and Risk Score sections - Add .claude/ to .gitignore - Bump version to 0.3.0; 29 tests, all passing
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 702f24c23f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Collect local IP address | ||
| - Collect listening network ports | ||
| - Collect Windows firewall status | ||
| - Collect firewall status (Windows and Linux) |
There was a problem hiding this comment.
Limit the Linux firewall claim to UFW
On Linux systems that use firewalld or raw nftables instead of UFW, this documentation now advertises firewall-status collection even though collect_firewall_status() only runs ufw status (sentinel_audit/collectors/firewall.py:10-11). If UFW is absent the audit returns an error, and if UFW is installed but inactive alongside another active firewall it can report misleading telemetry. Narrow this claim to UFW-based Linux hosts or add support for the other Linux firewall backends.
Useful? React with 👍 / 👎.
|
|
||
| ### Risky Port Detection | ||
|
|
||
| The findings engine flags the following ports when found listening: |
There was a problem hiding this comment.
Qualify risky-port detection as TCP-only
When a listed risky service is listening only over UDP, the documented promise is not met. The Linux collector requests UDP sockets with ss -tuln (sentinel_audit/collectors/network.py:16), but _extract_listening_ports() discards every row that does not contain listen (sentinel_audit/findings/network_findings.py:27-28); ss normally labels UDP sockets UNCONN. Windows netstat -ano UDP rows similarly lack LISTENING. Either document that the table applies only to TCP listeners or update the analyzer to inspect UDP rows.
Useful? React with 👍 / 👎.
No description provided.