Conversation
There was a problem hiding this comment.
Pull request overview
This PR rebrands the Android app’s package/namespace/applicationId from dk.au.aptg.dEdx to io.github.aptg.dedx, aligning Java package declarations, Gradle configuration, and JNI entrypoints to the new application ID.
Changes:
- Updated Java package declarations to
io.github.aptg.dedx. - Updated Gradle
namespaceandapplicationIdtoio.github.aptg.dedx. - Renamed JNI-exported native function entrypoints in
dEdx.cto match the new Java package.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/java/io/github/aptg/dedx/MainActivity.java | Updates package declaration to new app namespace. |
| app/src/main/java/io/github/aptg/dedx/InverseFragment.java | Updates package declaration to new app namespace. |
| app/src/main/java/io/github/aptg/dedx/DedxIdxNameAdapter.java | Updates package declaration to new app namespace. |
| app/src/main/java/io/github/aptg/dedx/DedxIdxName.java | Updates package declaration to new app namespace. |
| app/src/main/java/io/github/aptg/dedx/DedxFragment.java | Updates package declaration to new app namespace. |
| app/src/main/java/io/github/aptg/dedx/DedxAPI.java | Updates package declaration to new app namespace (JNI-bound class). |
| app/src/main/java/io/github/aptg/dedx/AboutActivity.java | Updates package declaration to new app namespace. |
| app/src/main/cpp/dEdx.c | Updates JNI function names to match new Java package. |
| app/build.gradle | Updates namespace and applicationId to io.github.aptg.dedx. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jint | ||
| Java_dk_au_aptg_dEdx_DedxAPI_dedxExit(JNIEnv* env, jobject thiz) { | ||
| Java_io_github_aptg_dedx_DedxAPI_dedxExit(JNIEnv* env, jobject thiz) { | ||
| int err = 0; |
There was a problem hiding this comment.
Native code still looks up DedxIdxName using the old class path (FindClass("dk/au/aptg/dEdx/DedxIdxName")). After changing the Java package/namespace to io.github.aptg.dedx, this FindClass will fail and JNI calls that build lists (programs/ions/materials) will return NULL / crash. Update the FindClass string to the new package path (io/github/aptg/dedx/DedxIdxName) to match the rebrand.
No description provided.