Decode keystore in workflow instead of Gradle"

[nbassler]

No description provided.

[Copilot]

Pull request overview

Updates the Android release signing flow to decode the keystore within the GitHub Actions workflow and have Gradle consume it via a file path, rather than decoding Base64 inside Gradle.

Changes:

• Replace Gradle-side Base64 keystore decoding with KEYSTORE_PATH-based signing.
• Add a workflow step to decode KEYSTORE_BASE64 into a temporary keystore file and pass its path to Gradle.
• Update the release build to enable signing based on the presence of KEYSTORE_PATH.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
app/build.gradle	Switch signing config from Base64 decoding to using a keystore file path via KEYSTORE_PATH.
.github/workflows/release.yml	Decode keystore in CI and pass the decoded file path into the Gradle build environment.

Comments suppressed due to low confidence (1)

app/build.gradle:32

• keyPassword is currently sourced from KEYSTORE_PASSWORD, but the workflow no longer provides a separate KEY_PASSWORD env var. If the key password differs from the keystore password (common), signing will fail. Recommend reading keyPassword from a dedicated env var (e.g., KEY_PASSWORD) and keeping storePassword tied to KEYSTORE_PASSWORD.

                storeFile = file(ksPath)
            }
            storePassword = System.getenv("KEYSTORE_PASSWORD") ?: ""
            keyAlias = System.getenv("KEY_ALIAS") ?: "dedx-upload"
            keyPassword = System.getenv("KEYSTORE_PASSWORD") ?: ""

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The workflow no longer passes a key password env var, but Gradle still needs keyPassword to sign. If the key password is different from the keystore password, the signing step will fail. Recommend reintroducing KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }} (or similar) and wiring Gradle to use it for keyPassword.

Suggested change

	KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
	KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
	KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}