fix(auth)!: change timestamp to ms since Unix epoch for effective replay protection#58
Open
VasilevNStas wants to merge 1 commit into
Open
fix(auth)!: change timestamp to ms since Unix epoch for effective replay protection#58VasilevNStas wants to merge 1 commit into
VasilevNStas wants to merge 1 commit into
Conversation
Contributor
Author
VasilevNStas
force-pushed
the
29-fix/timestamp-ms
branch
from
July 4, 2026 18:09
fee2ffe to
5c1ecf5
Compare
Contributor
Author
|
@davvd conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Auth.timestampfromuint32(minutes since project epoch) touint64 timestamp_ms(milliseconds since Unix epoch) for effective per-message replay protection.Problem
The previous
uint32 timestampused minute granularity. Every Auth sent within the same 60-second window carried the identical value. With the ±1 minute acceptance window, a captured frame could be replayed for up to 119 seconds. This is not a nonce — it's a coarse time window.Fix
uint32 timestamp = 2uint64 timestamp_ms = 2The big-endian serialization is now explicitly specified in the HMAC comment.
Migration
Breaking wire change — the Auth frame format changes. All Nodes and clients must update simultaneously:
timestamptotimestamp_msCloses #29