docs(auth): fix client_id origin — client generates it, not Hub#41
Open
VasilevNStas wants to merge 1 commit into
Open
docs(auth): fix client_id origin — client generates it, not Hub#41VasilevNStas wants to merge 1 commit into
VasilevNStas wants to merge 1 commit into
Conversation
Contributor
Author
|
@davvd please review |
Member
|
@VasilevNStas we have merge conflicts here, please resolve them and we'll merge |
VasilevNStas
force-pushed
the
9-docs/client-id-origin
branch
from
July 4, 2026 18:05
5aaf368 to
60cd3de
Compare
Contributor
Author
|
@davvd conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
Auth.client_iddocumentation: the client generates the ID locally (CSPRNG, 9 chars from alphabetABCDEFGHIJKLMNPQRSTUVWXYZ123456789), the Hub only stores the passed value.Confirmed by code:
ios/APNCommon/LegalPrincipal.swift—SystemRandomNumberGeneratorandroid/.../Principal.kt—kotlin.random.Randomhub/objects/hub/clients.rb—INSERT ... ON CONFLICT DO NOTHINGwith caller-supplied idCloses #9