Skip to content

#1 add ip_bytes to Property for raw-byte IPv4 encoding #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VasilevNStas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#1 add ip_bytes to Property for raw-byte IPv4 encoding #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ping.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ message Ping {

// Per-peer probe-failure counters accumulated since the previous
// Ping. The key is the peer Node's IPv4 address in dotted form
// ("203.0.113.7"); the value is the number of probes that failed
// (timeouts, refusals, etc.). Forwarded to the Hub so that
// unreachable Nodes can be retired.
// ("203.0.113.7"), derived from the four raw bytes of Peer.ip
// or Property.ip_bytes; the value is the number of probes that
// failed (timeouts, refusals, etc.). Forwarded to the Hub so
// that unreachable Nodes can be retired.
map<string, uint32> canaries = 2;
}
9 changes: 9 additions & 0 deletions pong.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,17 @@ message Property {
// Public IPv4 of the Node currently backing this slot, in dotted
// form ("203.0.113.7"). Empty / "0.0.0.0" while the slot is
// detached.
//
// Deprecated: use ip_bytes (field 9). Kept on the wire until all
// consumers — iOS, Android, Huawei, and Node — have migrated.
string ip = 4;

// Public IPv4 of the Node currently backing this slot, as four
// raw bytes in network byte order. Matches the encoding of
// Peer.ip and Welcome.ip so that clients can compare addresses
// without a format conversion.
bytes ip_bytes = 9;

// TCP port to dial on the backing Node. Always 443 in production
// but kept explicit so a Node may move to a different port
// without a client release.
Expand Down