refactor: drop pyref; add refloxide.python.model and tmm - #4
Merged
Conversation
Move the pure-Python TMM under refloxide.python, expose modeling via python.model, remove integrations.pyref, and retarget examples to py_* naming against Rust model vs python.model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refloxide.integrations.pyrefsurface (patch_pyrefand related) so installing/comparing against external pyref is no longer required.refloxide.python.tmmand addrefloxide.python.modelas the opt-in pure-Python modeling API; keep Rust TMM as the default package export.import refloxide.python.model as pywithpy_*naming (Rustrefloxide.modelvs python.model), and stop installing/patching pyref inscripts/develop.sh.Test plan
uv run pytestMPLBACKEND=Agg uv run python examples/model_objective_repl.pyMPLBACKEND=Agg uv run python examples/uni_tensor_znpc_repl.pyMPLBACKEND=Agg uv run python examples/mixed_uni_tensor_znpc_repl.pyimport refloxidedoes not pull pyref / integrationsimport refloxide.python.model as pyandfrom refloxide.python.tmm import uniaxial_reflectivitywork