[pull] trunk from WordPress:trunk#1
Open
pull[bot] wants to merge 2905 commits into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @desrosj602fd350-edb4-49c9-b593-d223f7449a82, @felixarntz. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
git-svn-id: https://develop.svn.wordpress.org/trunk@62153 602fd350-edb4-49c9-b593-d223f7449a82
Since button and media view CSS can sometimes be enqueued by extenders in contexts where either `wp-base-styles` are not present or the `body` wrapper class is omitted, these variables should use fallback values. Reviewed by audrasjb. Props huzaifaalmesbah, wildworks, mukesh27, noruzzaman, joedolson, sabernhardt, audrasjb, shailu25. Fixes #64840. git-svn-id: https://develop.svn.wordpress.org/trunk@62154 602fd350-edb4-49c9-b593-d223f7449a82
After [62117] through [62144] along with [62147] through [62149], a number of block directories included css files as the result of `npm build`. To fix this and prevent a recurrence when new blocks are added, this moves from the `svn:ignore` property needing to be set on each individual directory to using the `svn:global-ignores` property which is recursive.
This was accomplished by running the following commands:
{{{
svn propdel svn:ignore -R src/wp-includes/blocks/*
svn propset svn:global-ignores '*.css
*.js
*.js.map' src/wp-includes/blocks
}}}
Discussed in https://wordpress.slack.com/archives/C08D0Q6BHNY/p1774546046110849
Reviewed-by:dmsnell and jonsurrell.
Props dmsnell, johnbillion, jonsurrell, jorbin.
See #64393.
git-svn-id: https://develop.svn.wordpress.org/trunk@62155 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [57145], [59931]. Reviewed by westonruter, swissspidy, SergeyBiryukov. Props pbearne, SirLouen, wildworks, westonruter, swissspidy, audrasjb, juanmaguitar, rollybueno, welcher, SergeyBiryukov. Fixes #59941. git-svn-id: https://develop.svn.wordpress.org/trunk@62156 602fd350-edb4-49c9-b593-d223f7449a82
In [61873], the `build` script started failing in some environemnts due to logic that added a requirement for `php-cli`. While WordPress itself cannot be run without PHP, the build script has never required PHP to be present to prepare `wordpress-develop` for use. This adjusts the relevant code to make use of the `php-array-reader` package instead. Reviewed by peterwilsoncc. Props dmsnell, peterwilsoncc, gaisma22, SirLouen, sabernhardt, manhar. Fixes #64925. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62157 602fd350-edb4-49c9-b593-d223f7449a82
This removes a change that was unintentionally included in the previous commit. Reviewed by peterwilsoncc. Unprops desrosj. Props peterwilsoncc. Fixes #64925. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62158 602fd350-edb4-49c9-b593-d223f7449a82
Reviewed by SergeyBiryukov. See #64966. git-svn-id: https://develop.svn.wordpress.org/trunk@62160 602fd350-edb4-49c9-b593-d223f7449a82
Trunk is now 7.1-alpha. Reviewed by SergeyBiryukov. See #64966. git-svn-id: https://develop.svn.wordpress.org/trunk@62161 602fd350-edb4-49c9-b593-d223f7449a82
…down on the setup screen. This changeset ensures the hover/focus color of the setup screen's language dropdown use the new default admin color scheme. Reviewed by SergeyBiryukov. Props huzaifaalmesbah, noruzzaman. Fixes #64961. See #64308. git-svn-id: https://develop.svn.wordpress.org/trunk@62163 602fd350-edb4-49c9-b593-d223f7449a82
Since this workflow tests based on tagged versions available through WP-CLI, the pre-release versions need to be used. Follow up to [62160]. See #64966. git-svn-id: https://develop.svn.wordpress.org/trunk@62166 602fd350-edb4-49c9-b593-d223f7449a82
This removes unnecessary uses of the `sprintf()` function when localizing or outputting static strings. These changes simplify the code and improve readability without affecting functionality. Props Soean. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62167 602fd350-edb4-49c9-b593-d223f7449a82
Configured the Real Time Collaboration post type to be excluded from exports by default. The data is considered ephemeral and includes data on post IDs that may not match the IDs of posts on the importing site. Introduces a test to the export test suite to ensure that post types set to be excluded from exports are, in fact, excluded from exports. Props peterwilsoncc, desrosj, westonruter, jorbin, mukesh27, czarate. Fixes #64964. git-svn-id: https://develop.svn.wordpress.org/trunk@62168 602fd350-edb4-49c9-b593-d223f7449a82
A test in the `external-http` group that detects when the recommended version of MySQL is too old is failing due to an upstream change to the content of version documentation pages. Because the required information is no longer on the page, this switches to using the public API from endoflife.date. This site is an open source (MIT licensed) resource that is actively maintained. Props peterwilsoncc. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@62170 602fd350-edb4-49c9-b593-d223f7449a82
`line-height` values that were previously used to match the height of input fields affect the height of the background shown when text inside those fields is selected. Removing these `line-height` declarations allows the text selection highlight to render more naturally. Additionally, update the height of the custom Date/Time format input fields on the General Settings screen to `32px` to align with the new design system. Props arkaprabhachowdhury, audrasjb, hmrisad, huzaifaalmesbah, manhar, manishxdp, noruzzaman, ozgursar, r1k0, sachinrajcp123, wildworks. Fixes #64763. git-svn-id: https://develop.svn.wordpress.org/trunk@62171 602fd350-edb4-49c9-b593-d223f7449a82
This makes minor code simplifications by removing unnecessary ternary operations and directly assigning boolean expressions. These changes make the code easier to read and maintain, but do not alter the underlying logic. Props Soean. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62173 602fd350-edb4-49c9-b593-d223f7449a82
…rovider. Developed in #11382 Follow-up to r41722. Props westonruter, swissspidy, SergeyBiryukov. See #41562. Fixes #41562. git-svn-id: https://develop.svn.wordpress.org/trunk@62174 602fd350-edb4-49c9-b593-d223f7449a82
[https://www.php.net/manual/en/function.is-integer.php is_integer()] is an alias for [https://www.php.net/manual/en/function.is-int.php is_int()]. While they function identically, the WordPress Coding Standards and modern PHP practices generally lean towards using the official function name rather than its alias to maintain consistency across the codebase. Props Soean, westonruter, SergeyBiryukov. See #64913. git-svn-id: https://develop.svn.wordpress.org/trunk@62175 602fd350-edb4-49c9-b593-d223f7449a82
…age_src()` and `wp_getimagesize()`.
* Add `is_array()` checks before accessing return values from `wp_get_attachment_image_src()` in `get_oembed_response_data_rich()`, `wp_playlist_shortcode()`, and `wp_prepare_attachment_for_js()`.
* Guard `wp_getimagesize()` calls within `wp_get_attachment_image_src()` itself.
* Ensure `wp_get_attachment_image_src()` always returns the expected `array{0: string, 1: int, 2: int, 3: bool}` type or `false` by normalizing the filter result with explicit type casting and default values.
* Add `@phpstan-return` annotations to both `wp_get_attachment_image_src()` and `wp_getimagesize()` for the specific array shapes.
Developed in #11073
Props hbhalodia, westonruter, mukesh27, edent, ozgursar, roshniahuja14.
Fixes #64742.
git-svn-id: https://develop.svn.wordpress.org/trunk@62176 602fd350-edb4-49c9-b593-d223f7449a82
…elated functions. Replace `void` in union return types with `null`, `false`, or `never` as appropriate, and add explicit `return null` statements where methods previously fell through without a return value. Methods updated in `wpdb`: `prepare()`, `print_error()`, `check_connection()`, `get_row()`, `get_col_info()`, `bail()`, `check_database_version()`. Also adds `@return never` to `dead_db()` and fixes the `@phpstan-return` syntax for `wp_die()`. Developed in #11009 Props apermo, westonruter, xate, mukesh27, SergeyBiryukov. Fixes #64703. git-svn-id: https://develop.svn.wordpress.org/trunk@62177 602fd350-edb4-49c9-b593-d223f7449a82
… annotations. In PHP's type system, `void` means a function does not return a value and cannot be part of a union type. Many functions in core were documented as returning e.g. `string|void` while actually returning `null` implicitly via bare `return;` statements. This replaces `void` with `null` in union return types, adds explicit `return null;` statements, and updates `@return` annotations across 22 files in `wp-includes`. Additionally: * Adds `@return never` for `WP_Recovery_Mode::redirect_protected()`. * Fixes `WP_Theme_JSON::set_spacing_sizes()` to use `@return void` instead of `@return null|void`. * Removes `void` from return types where the function always returns a value or dies: `remove_theme_support()`, `WP_Recovery_Mode::handle_error()`. * Fixes `wp_die()` return type from `never|void` to `void` with clarified description. * Initializes `$primary` variable in `get_active_blog_for_user()` to prevent a possible undefined variable notice. Developed in #11012 Follow-up to r62177, r61766, r61719. Props apermo, xateman, westonruter, parthvataliya, nimeshatxecurify. See #64704. git-svn-id: https://develop.svn.wordpress.org/trunk@62178 602fd350-edb4-49c9-b593-d223f7449a82
…on PHPDoc annotations. Replace `void` in union return types with `null` or remove it where the function always returns a value or dies, across 8 files in `wp-admin/includes`. Adds explicit `return null;` statements where functions previously fell through without a return value. Additionally: * Adds `@return never` for `media_send_to_editor()` and removes misleading `return` from its callers. * Removes `void` from return types where the function always returns a value or exits: `write_post()`, `WP_Importer::set_blog()`, `WP_Importer::set_user()`. * Replaces `mixed|void` with a specific array shape for `WP_Site_Health::perform_test()`. Developed in #11008 Follow-up to r62178, r62177, r61766, r61719. Props apermo, xate, westonruter, mukesh27, desrosj. Fixes #64702. git-svn-id: https://develop.svn.wordpress.org/trunk@62179 602fd350-edb4-49c9-b593-d223f7449a82
Validate `setting_name`, `constant_name`, and `env_var_name` in connector
registration — reject invalid values with `_doing_it_wrong()` instead of
silently falling back.
Change the auto-generated `setting_name` pattern from
`connectors_ai_{$id}_api_key` to `connectors_{$type}_{$id}_api_key` so it
works for any connector type. Built-in AI providers infer their names using
the existing `connectors_ai_{$id}_api_key` convention, preserving backward
compatibility.
Add `constant_name` and `env_var_name` as optional authentication fields,
allowing connectors to declare explicit PHP constant and environment
variable names for API key lookup. AI providers auto-generate these using
the `{CONSTANT_CASE_ID}_API_KEY` convention.
Refactor `_wp_connectors_get_api_key_source()` to accept explicit
`env_var_name` and `constant_name` parameters instead of deriving them from
the provider ID. Environment variable and constant checks are skipped when
not provided.
Generalize REST dispatch, settings registration, and script module data to
work with all connector types, not just `ai_provider`. Settings
registration skips already-registered settings. Non-AI connectors determine
`isConnected` based on key source.
Replace `isInstalled` with `pluginFile` in script module data output to fix
plugin entity ID resolution on the frontend.
Update PHPDoc to reflect current behavior — widen `type` from literal
`'ai_provider'` to `non-empty-string`, document new authentication fields,
and use Anthropic examples throughout.
Props gziolo, jorgefilipecosta.
Fixes #64957.
git-svn-id: https://develop.svn.wordpress.org/trunk@62180 602fd350-edb4-49c9-b593-d223f7449a82
…st tables. Props TobiasBg, rcorrales, opurockey, rahultank, SergeyBiryukov. Fixes #64975. git-svn-id: https://develop.svn.wordpress.org/trunk@62182 602fd350-edb4-49c9-b593-d223f7449a82
…it HTML file. The markup had surely been copied from the PHP source file, as opposed to being copied from the rendered HTML, as it should have been. Developed in #11403 Follow-up to r41773. Props westonruter, jonsurrell, desrosj, SergeyBiryukov. See #64225, #40104. git-svn-id: https://develop.svn.wordpress.org/trunk@62184 602fd350-edb4-49c9-b593-d223f7449a82
B !== A (at least in this instance). See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@62463 602fd350-edb4-49c9-b593-d223f7449a82
The `tests/phpunit` part of the logging file path in the `multisite.xml` configuration file is unnecessary because it already exists within that directory. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@62464 602fd350-edb4-49c9-b593-d223f7449a82
Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov. See #58715. git-svn-id: https://develop.svn.wordpress.org/trunk@62465 602fd350-edb4-49c9-b593-d223f7449a82
Adds CSS to distinguish button selected or active states in Windows High Contrast Mode. Props sabernhardt, wildworks, manhar, joedolson. Fixes #65153. git-svn-id: https://develop.svn.wordpress.org/trunk@62467 602fd350-edb4-49c9-b593-d223f7449a82
Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov. See #58715. git-svn-id: https://develop.svn.wordpress.org/trunk@62468 602fd350-edb4-49c9-b593-d223f7449a82
Avoid layout element shift by setting position attributes on `.media-bg-overlay` in all viewports, avoiding redraw of flex layout. Props abduremon, mohamedahamed, wildworks, khokansardar, darshitrajyaguru97, joedolson. Fixes #65296. git-svn-id: https://develop.svn.wordpress.org/trunk@62469 602fd350-edb4-49c9-b593-d223f7449a82
…eared. The throttled `input` handler in `wp.media.view.MediaFrame.Manage` only called `gridRouter.navigate()` when the search value was non-empty, so emptying the search box left the `?search=` query parameter in the address bar. Reloading the page then re-parsed that stale parameter and refilled the input. So now the `navigate()` method is called unconditionally when the input changes in order to reset the URL back to the base `upload.php`. Developed in #11938. Follow-up to r41021. Props mohamedahamed, abduremon, jorbin, ekla, drwpcom, anukasha, huzaifaalmesbah, noruzzaman, rejaulalomkhan, hmbashar, nadabulija, robert681, pedrofigueroa1989, westonruter. Fixes #65298. git-svn-id: https://develop.svn.wordpress.org/trunk@62470 602fd350-edb4-49c9-b593-d223f7449a82
Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov. See #58715. git-svn-id: https://develop.svn.wordpress.org/trunk@62471 602fd350-edb4-49c9-b593-d223f7449a82
Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov. See #58715. git-svn-id: https://develop.svn.wordpress.org/trunk@62472 602fd350-edb4-49c9-b593-d223f7449a82
Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov. See #58715. git-svn-id: https://develop.svn.wordpress.org/trunk@62473 602fd350-edb4-49c9-b593-d223f7449a82
The previous `round( (float) $maybe_integer ) === (float) $maybe_integer` check rejected large integers on PHP 8.4. The check itself was fragile: a PHP `float` (a 64-bit IEEE-754 double) can represent every integer exactly only up to 2^53, so casting larger values is lossy. Nevertheless, that lossiness alone did not reject anything, since both sides of the comparison were munged identically. What actually broke it was a `round()` regression in PHP 8.4, where `round( (float) $x )` can return a value different from `(float) $x` for certain numbers. That inequality caused canonical integers still valid for a `BIGINT UNSIGNED` column (such as unusually high post IDs) to be incorrectly rejected by REST validation, only on PHP 8.4+. The function now short-circuits returning true for native integers and canonical integer strings so that integer-like values of any magnitude are detected correctly. Decimal and scientific-notation strings (and floats) retain their historical behavior, including the existing float comparison, now rewritten as a `floor()` check whose strict equality compares a float to its own floor and is therefore exact. The limitations around `PHP_INT_MAX` and fractional magnitudes beyond `2 ** 53` are documented on the function, and the data provider gains coverage for large integers, negative floats, and scientific notation. Developed in #11893. Follow-up to r48306. Props siliconforks, gautam23, westonruter, kevinfodness, mboynes, desrosj. Fixes #65271. git-svn-id: https://develop.svn.wordpress.org/trunk@62474 602fd350-edb4-49c9-b593-d223f7449a82
…lass_name()` block render filter callback. The `wp_render_elements_class_name()` function reads the `className` block attribute and passes it straight to `preg_match()`. While `className` is expected to be a string, malformed or corrupted stored block data can hold another type, such as an array, which triggers a fatal `TypeError` on PHP 8+. Guard against this by returning the block content unchanged when `className` is not a string. While here, align the implementation with `wp_render_custom_css_class_name()` from r62359: replace the regular expression with a `str_contains()` short-circuit followed by an HTML-spec-compliant `strtok()` walk over the class tokens. This also corrects a latent matching bug: the previous `\bwp-elements-\S+\b` pattern treated the hyphen as a word boundary, so a class such as `my-wp-elements-foo` was erroneously matched. Tokenizing the attribute first ensures only a standalone `wp-elements-*` class is applied. Add regression tests for the non-string and substring-prefix cases, and resolve PHPStan errors at rule level 10 (`missingType.iterableValue`, `offsetAccess.nonOffsetAccessible`, `argument.type`) by adding an array shape to the `@phpstan-param` tag. Developed in #12028 and WordPress/gutenberg#78841. Follow-up to r58074, r62359. Props aaronrobertshaw, andrewserong, mukesh27, westonruter. Fixes #65379. git-svn-id: https://develop.svn.wordpress.org/trunk@62475 602fd350-edb4-49c9-b593-d223f7449a82
The documented return type is `WP_Term|WP_Post_Type|WP_Post|WP_User|null`, but `get_queried_object()` could return `false` from author queries because `get_userdata()` yields `false` when the resolved author ID is `null` or matches no user. Guard the `get_userdata()` call and its result so `$this->queried_object` stays `null` in those cases. The adjacent posts page branch is hardened the same way, since `get_post()` can return `null` for a missing or deleted page, which previously caused a property access on `null`. Developed in #12069. Follow-up to r52822, r3290. Props tusharbharti, tommusrhodus, yusufmudagal, westonruter. Fixes #65400. git-svn-id: https://develop.svn.wordpress.org/trunk@62476 602fd350-edb4-49c9-b593-d223f7449a82
The `@deprecated` tags for the legacy `contextual_help_list`, `contextual_help`, and `default_contextual_help` filters pointed to `{@see get_current_screen()->add_help_tab()}` and `{@see get_current_screen()->remove_help_tab()}`. These method-call chains are not resolvable references, so they rendered as broken links on the Developer Reference site (and in IDEs such as PhpStorm). Replace them with references that resolve: `get_current_screen()`, `WP_Screen::add_help_tab()`, and `WP_Screen::remove_help_tab()`.
Developed in #12071.
Follow-up to r46685.
Props ekamran, yusufmudagal, dhruvang21, codesmith32.
Fixes #65401.
git-svn-id: https://develop.svn.wordpress.org/trunk@62477 602fd350-edb4-49c9-b593-d223f7449a82
Adds support for setting responsive layout, block spacing and child layout styles. Props isabel_brison, ramonopoly, audrasjb, desrosj, sabernhardt. Fixes #65164. git-svn-id: https://develop.svn.wordpress.org/trunk@62478 602fd350-edb4-49c9-b593-d223f7449a82
Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov. See #58715. git-svn-id: https://develop.svn.wordpress.org/trunk@62479 602fd350-edb4-49c9-b593-d223f7449a82
The spinner that appeared during filtering was positioned beneath the fields, causing a scrollbar in the filter wrapper container. While only visible during scrolling on MacOS, it was persistently visible on Windows. Fixes the alignment of the toolbar to appear with predictable alignment to the select fields without generating a scrollbar. Follow up to [61757]. Props luismulinari, yogeshbhutkar, dhruvang21, r1k0, sabernhardt, wildworks, audrasjb, joedolson. Fixes #65275. See #23562. git-svn-id: https://develop.svn.wordpress.org/trunk@62480 602fd350-edb4-49c9-b593-d223f7449a82
The image editor help toggle icon used a hardcoded classic blue color. Replace it with a CSS custom property so the icon follows the user's admin color scheme. Props dervishov, huzaifaalmesbah, jamesbregenzer, mukesh27, ozgursar, wildworks. Fixes #64937. git-svn-id: https://develop.svn.wordpress.org/trunk@62481 602fd350-edb4-49c9-b593-d223f7449a82
…tize_email This adds support for the unicode address extensions in RFC 6530-3 and refactors the code so there are fewer long regexes and less duplication between sanitize_email and is_email. A new class, WP_Email_Address, provides the shared parts. Opting out of unicode support is easy, default-filters.php adds unicode support by adding filters, which can be removed. `sanitize_email` no longer does major changes like removing an entire subdomain from someone's address, it only cleans up things like soft hyphens and whitespace — changes that happen when coping an email address from text. Developed in: #5237 Discussed in: https://core.trac.wordpress.org/ticket/31992 Props agulbra, akirk, benniledl, dmsnell, ironprogrammer, justlevine, mdawaffe, mukeshpanchal27, SirLouen, tusharbharti. Fixes #31992. git-svn-id: https://develop.svn.wordpress.org/trunk@62482 602fd350-edb4-49c9-b593-d223f7449a82
Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov. Fixes #58715. git-svn-id: https://develop.svn.wordpress.org/trunk@62483 602fd350-edb4-49c9-b593-d223f7449a82
Detected while fuzz-testing the UTF-8 handling code, this defect meant that the tests were verifying the wrong behavior. Namely, they verified a stringification of ASCII digits, which always converted plainly, when they were meant to test handling of invalid UTF-8 sequences. This patch fixes the test by calling `chr()` on the byte values before concatenating into a big string. Developed in: #12147 Discussed in: https://core.trac.wordpress.org/ticket/65372 Props dmsnell, jonsurrell. Follow-up to: [60950]. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62484 602fd350-edb4-49c9-b593-d223f7449a82
…sion. Found during fuzzing work on the HTML API and adjacent code. The previous version of this function used a Unicode PCRE to detect noncharacter code points, but that invocation failed if the input string contained sequences of invalid UTF-8 bytes. This patch replaces the Unicode PCRE with a mapped sequence of raw bytes. This version works in environments without Unicode support and it works when invalid bytes are present, making it possible to remove the fallback function as well. Developed in: #12148 Discussed in: https://core.trac.wordpress.org/ticket/65372 Follow-up to [61000]. Props dmsnell, jonsurrell. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62485 602fd350-edb4-49c9-b593-d223f7449a82
The `wow-actions/welcome` action has not been updated for over 2 years and is currently configured to run on `Node20`. With GitHub now actively removing support for Node.js 20.x within the GitHub Actions environment, any action explicitly using `Node20` will break. This replaces `wow-actions/welcome` with the `actions/first-interaction` action, which is an action officially maintained by GitHub and offers the same functionality. Props khokansardar, mukesh27, desrosj. Fixes #65432. git-svn-id: https://develop.svn.wordpress.org/trunk@62486 602fd350-edb4-49c9-b593-d223f7449a82
This was brought up during fuzz testing of the HTML API. After polyfilling `mb_chr()` and relying on it in the HTML decoder, it became possible that for sites with a non-UTF-8 charset selected, then the creation of text from code points when decoding numeric character references might produce corrupted text, or text which encodes to non-UTF-8 bytes. While for these sites, there are broader issues with non-UTF-8 support, this change ensures that code point encoding remains deterministic. Developed in: #12155 Discussed in: https://core.trac.wordpress.org/ticket/65372 Follow-up to [62424]. Props dmsnell, jonsurrell. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62487 602fd350-edb4-49c9-b593-d223f7449a82
This addresses PHPStan rule level 10 errors with these functions: * `_get_cron_array()` * `_set_cron_array()` * `_upgrade_cron_array()` See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62488 602fd350-edb4-49c9-b593-d223f7449a82
Developed in #12039. Props khokansardar, sabernhardt, sanayasir, tusharaddweb. Fixes #65384. git-svn-id: https://develop.svn.wordpress.org/trunk@62489 602fd350-edb4-49c9-b593-d223f7449a82
…on`. While not documented as required, both `issue_message` and `pr_message` are required inputs for this action. Follow up to [62486]. Fixes #65432. git-svn-id: https://develop.svn.wordpress.org/trunk@62490 602fd350-edb4-49c9-b593-d223f7449a82
Improve the PHPDoc docblocks in `WP_List_Table` and `WP_Plugins_List_Table` for accuracy, completeness, and consistency with WordPress core documentation standards. Adds missing `@since` tags and corrects several existing versions, adds summary descriptions to all previously bare method and property docblocks, and refines type annotations with precise generic array types. Developed in #10989. Follow-up to r30679, r31127, r32642, r32654. Props huzaifaalmesbah, westonruter, noruzzaman. See #64896. git-svn-id: https://develop.svn.wordpress.org/trunk@62491 602fd350-edb4-49c9-b593-d223f7449a82
Discovered during fuzz-testing of the HTML API. Adjusted foreign attributes, such as `xlink:href`, were being normalized with a space instead of a colon through `::serialize_token()`. This led to the creation of two attributes on output instead of the proper singular attribute. This patch corrects the issue by ensuring that the attribute namespace and name are separated by a colon when serializing. Developed in: #12140 Discussed in: https://core.trac.wordpress.org/ticket/65372 Props jonsurrell. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62492 602fd350-edb4-49c9-b593-d223f7449a82
…odes. Follow-up to [62444]. Props khokansardar, huzaifaalmesbah, isabel_brison, sabernhardt, manhar, SergeyBiryukov. Fixes #65390. git-svn-id: https://develop.svn.wordpress.org/trunk@62493 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )