refactor(swebp): 重构swebp镜像操作逻辑,优化镜像管理粒度#385
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces session-scoped container cleanup for SWE-bench Pro, mirroring the session isolation implementation in SWE-bench. It refactors the utilities in swebench/utils.py to support a parameterizable label_key, allowing them to be reused by swebench_pro. The old name-filter-based container cleanup in swebench_pro is replaced with session-scoped cleanup to prevent concurrently running tasks from removing each other's containers. Comprehensive unit tests and a multi-process concurrency test have been added to validate the session isolation. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2a23f09 to
abfd908
Compare
abfd908 to
0de60de
Compare
1. 归一swe和swebp两个数据集的镜像操作,消除冗余代码。 2. 优化swebp临时容器清理逻辑,以Session粒度管理生命周期
f12089a to
3cc8f5b
Compare
| @@ -7,7 +7,7 @@ | |||
| import shutil | |||
There was a problem hiding this comment.
remove unused import
Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献,我们非常重视。以下说明将使您的拉取请求更健康,更易于获得反馈。如果您不理解某些项目,请不要担心,只需提交拉取请求并从维护人员那里寻求帮助即可。
PR Type / PR类型
Related Issue | 关联 Issue
Fixes #380
🔍 Motivation / 变更动机
📝 Modification / 修改内容
📐 Associated Test Results / 关联测试结果
Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接,例如 CI 管道、测试报告等。
Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改?如果是,请描述它如何破坏兼容性,以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。
If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降,请描述性能下降的影响和预期的性能改进。
🌟 Use cases (Optional) / 使用案例(可选)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能,最好在此处列出一些用例并更新文档。
✅ Checklist / 检查列表
Before PR:
After PR:
👥 Collaboration Info / 协作信息
🌟 Useful CI Command / 实用的CI命令
/gemini review/gemini summary/gemini help/readthedocs build