Skip to content

bugfix: Support for extracting answers expressed in thousand separato… #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yejj710 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix: Support for extracting answers expressed in thousand separato… #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ais_bench/benchmark/datasets/gsm8k.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def gsm8k_dataset_postprocess(text: str) -> str:

@TEXT_POSTPROCESSORS.register_module('gsm8k')
def gsm8k_postprocess(text: str) -> str:
text = text.split('Question:')[0]
text = text.split('Question:')[0].replace(',', '')

@gemini-code-assist gemini-code-assist Bot Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Blindly replacing all commas with an empty string can lead to incorrect parsing of numbers that are separated by commas without spaces (e.g., a list of numbers like 1,2 or coordinates). For example, 1,2 would be merged into 12, causing the postprocessor to extract 12 instead of 2.

To safely remove only thousand separators, you can use a regular expression that targets commas preceded by a digit and followed by exactly three digits (and a word boundary or decimal point).

Suggested change
text = text.split('Question:')[0].replace(',', '')
text = re.sub(r'(?<=\d),(?=\d{3}\b)', '', text.split('Question:')[0])

numbers = re.findall(r'\-?\d+\.\d+|\-?\d+', text)
if not numbers:
return 'NULL'
Expand Down
Loading