WIP(core): support custom role for tool result - #870
Draft
li-yechao wants to merge 1 commit into
Draft
Conversation
WalkthroughThis change implements a new Changes
|
| if (toolCalls.length === 1 && firstToolCall) { | ||
| const tool = toolsMap.get(firstToolCall.function.name); | ||
| if (tool?.roleInToolUse === "user") { | ||
| await session.endMessage({}, { role: "agent", toolCalls }, options); |
There was a problem hiding this comment.
There's a parameter mismatch in the endMessage call. The method signature expects (result, message, options) but you're passing ({}, message, options).
- await session.endMessage({}, { role: "agent", toolCalls }, options);
+ await session.endMessage({ role: "agent", toolCalls }, undefined, options);
li-yechao
marked this pull request as draft
January 5, 2026 00:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Major Changes
Screenshots
Test Plan
Checklist
Summary by AIGNE
Release Notes
New Feature:
roleInToolUseconfiguration option to agent settings, allowing tools to be executed with custom user rolesRefactor:
This update enables more flexible tool interaction patterns by allowing agents to customize how tool results are presented and processed within conversations.