fix: correct TTS voice parameter name in asset_based pipeline#129
Open
hobostay wants to merge 1 commit intoAIDC-AI:mainfrom
Open
fix: correct TTS voice parameter name in asset_based pipeline#129hobostay wants to merge 1 commit intoAIDC-AI:mainfrom
hobostay wants to merge 1 commit intoAIDC-AI:mainfrom
Conversation
The `TTSService.__call__` method accepts `voice` as the parameter name, but `asset_based.py` was passing `voice_id=` instead. Since `voice_id` was not in the method signature, it was silently captured by `**params` and ignored by the local Edge TTS path, causing the default voice to always be used regardless of user configuration. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asset_based.pyline 585 passesvoice_id=config.voice_idtoself.core.tts()TTSService.__call__(tts_service.py:73) acceptsvoice, notvoice_idvoice_idkwarg was silently captured by**paramsand ignored by the local Edge TTS code pathBefore
After
Test plan
TTSService.__call__parameter name isvoice(tts_service.py:73)voice_idgoes to**paramsand is not used by_call_local_ttsself.core.tts()usevoice_id=incorrectly🤖 Generated with Claude Code